Compare commits

...

7 Commits

Author SHA1 Message Date
dkhang97
1e5fb25e22 - Update Travis configuration; 2019-09-24 00:38:23 -07:00
dkhang97
7b9401e8f0 - Update karma version; 2019-08-15 15:49:06 -07:00
duykhang53
8878aa2f88 Update karma.conf.js 2019-08-15 15:36:32 -07:00
duykhang53
025162d345 Update .travis.yml 2019-08-15 15:24:42 -07:00
duykhang53
02b0c1db60 Update .travis.yml 2019-08-15 15:15:03 -07:00
duykhang53
732eb2d2a9 Update .travis.yml 2019-08-15 15:11:02 -07:00
dkhang97
6226188df3 - Implement of promise for filter function; 2019-08-15 14:46:09 -07:00
7 changed files with 16835 additions and 52 deletions

View File

@@ -1,11 +1,13 @@
language: node_js language: node_js
node_js: node_js:
- "6" - "10.15.0"
sudo: required
services:
- xvfb
before_install: before_install:
- export CHROME_BIN=chromium-browser - google-chrome-stable --headless --disable-gpu --remote-debugging-port=9222 http://localhost &
- export DISPLAY=:99.0
- sh -e /etc/init.d/xvfb start
script: script:
- npm run pretest - npm run pretest
@@ -15,6 +17,7 @@ after_success:
- ./node_modules/.bin/codecov - ./node_modules/.bin/codecov
addons: addons:
chrome: stable
firefox: "latest" firefox: "latest"
apt: apt:
sources: sources:

View File

@@ -48,6 +48,7 @@ module.exports = function (config) {
if (process.env.TRAVIS) { if (process.env.TRAVIS) {
configuration.browsers = ['Chrome_travis_ci']; configuration.browsers = ['Chrome_travis_ci'];
configuration.singleRun = true;
} }
if (process.env.SAUCE) { if (process.env.SAUCE) {

16759
package-lock.json generated Normal file

File diff suppressed because it is too large Load Diff

View File

@@ -84,8 +84,8 @@
"jasmine-core": "2.5.2", "jasmine-core": "2.5.2",
"jasmine-data-provider": "2.2.0", "jasmine-data-provider": "2.2.0",
"jasmine-spec-reporter": "3.2.0", "jasmine-spec-reporter": "3.2.0",
"karma": "1.4.0", "karma": "^4.2.0",
"karma-chrome-launcher": "^2.0.0", "karma-chrome-launcher": "^3.1.0",
"karma-cli": "^1.0.1", "karma-cli": "^1.0.1",
"karma-coverage-istanbul-reporter": "^1.3.0", "karma-coverage-istanbul-reporter": "^1.3.0",
"karma-jasmine": "^1.0.2", "karma-jasmine": "^1.0.2",

View File

@@ -1,12 +1,14 @@
import { Directive, EventEmitter, ElementRef, HostListener, Input, Output } from '@angular/core'; import { Directive, ElementRef, EventEmitter, HostListener, Input, Output } from '@angular/core';
import { FileUploader, FileUploaderOptions } from './file-uploader.class'; import { FileUploader, FileUploaderOptions, FilterFunction } from './file-uploader.class';
@Directive({ selector: '[ng2FileDrop]' }) @Directive({ selector: '[ng2FileDrop]' })
export class FileDropDirective { export class FileDropDirective {
@Input() public uploader: FileUploader; @Input() public uploader: FileUploader;
// tslint:disable-next-line:no-input-rename
@Input('ng2FileFilter') public filter: FilterFunction['fn'];
@Output() public fileOver: EventEmitter<any> = new EventEmitter(); @Output() public fileOver: EventEmitter<any> = new EventEmitter();
@Output() public onFileDrop: EventEmitter<File[]> = new EventEmitter<File[]>(); @Output() public onFileDrop: EventEmitter<FileList> = new EventEmitter<FileList>();
protected element: ElementRef; protected element: ElementRef;
@@ -22,7 +24,7 @@ export class FileDropDirective {
return {}; return {};
} }
@HostListener('drop', [ '$event' ]) @HostListener('drop', ['$event'])
public onDrop(event: any): void { public onDrop(event: any): void {
let transfer = this._getTransfer(event); let transfer = this._getTransfer(event);
if (!transfer) { if (!transfer) {
@@ -30,14 +32,17 @@ export class FileDropDirective {
} }
let options = this.getOptions(); let options = this.getOptions();
let filters = this.getFilters(); let filters = typeof this.filter === 'function' ? [{
name: 'ng2FileDropDirectiveFilter',
fn: this.filter
}, ...options.filters] : this.getFilters();
this._preventAndStop(event); this._preventAndStop(event);
this.uploader.addToQueue(transfer.files, options, filters); this.uploader.addToQueue(transfer.files, options, filters);
this.fileOver.emit(false); this.fileOver.emit(false);
this.onFileDrop.emit(transfer.files); this.onFileDrop.emit(transfer.files);
} }
@HostListener('dragover', [ '$event' ]) @HostListener('dragover', ['$event'])
public onDragOver(event: any): void { public onDragOver(event: any): void {
let transfer = this._getTransfer(event); let transfer = this._getTransfer(event);
if (!this._haveFiles(transfer.types)) { if (!this._haveFiles(transfer.types)) {
@@ -49,10 +54,10 @@ export class FileDropDirective {
this.fileOver.emit(true); this.fileOver.emit(true);
} }
@HostListener('dragleave', [ '$event' ]) @HostListener('dragleave', ['$event'])
public onDragLeave(event: any): any { public onDragLeave(event: any): any {
if ((this as any).element) { if ((this as any).element) {
if (event.currentTarget === (this as any).element[ 0 ]) { if (event.currentTarget === (this as any).element[0]) {
return; return;
} }
} }
@@ -61,11 +66,11 @@ export class FileDropDirective {
this.fileOver.emit(false); this.fileOver.emit(false);
} }
protected _getTransfer(event: any): any { protected _getTransfer(event: any): DragEvent['dataTransfer'] {
return event.dataTransfer ? event.dataTransfer : event.originalEvent.dataTransfer; // jQuery fix; return event.dataTransfer ? event.dataTransfer : event.originalEvent.dataTransfer; // jQuery fix;
} }
protected _preventAndStop(event: any): any { protected _preventAndStop(event: Event): any {
event.preventDefault(); event.preventDefault();
event.stopPropagation(); event.stopPropagation();
} }

View File

@@ -1,10 +1,12 @@
import { Directive, EventEmitter, ElementRef, Input, HostListener, Output } from '@angular/core'; import { Directive, ElementRef, EventEmitter, HostListener, Input, Output } from '@angular/core';
import { FileUploader } from './file-uploader.class'; import { FileUploader, FilterFunction } from './file-uploader.class';
@Directive({ selector: '[ng2FileSelect]' }) @Directive({ selector: '[ng2FileSelect]' })
export class FileSelectDirective { export class FileSelectDirective {
@Input() public uploader: FileUploader; @Input() public uploader: FileUploader;
// tslint:disable-next-line:no-input-rename
@Input('ng2FileFilter') public filter: FilterFunction['fn'];
@Output() public onFileSelected: EventEmitter<File[]> = new EventEmitter<File[]>(); @Output() public onFileSelected: EventEmitter<File[]> = new EventEmitter<File[]>();
protected element: ElementRef; protected element: ElementRef;
@@ -29,7 +31,10 @@ export class FileSelectDirective {
public onChange(): any { public onChange(): any {
let files = this.element.nativeElement.files; let files = this.element.nativeElement.files;
let options = this.getOptions(); let options = this.getOptions();
let filters = this.getFilters(); let filters = typeof this.filter === 'function' ? [{
name: 'ng2FileSelectDirectiveFilter',
fn: this.filter
}, ...options.filters] : this.getFilters();
this.uploader.addToQueue(files, options, filters); this.uploader.addToQueue(files, options, filters);
this.onFileSelected.emit(files); this.onFileSelected.emit(files);

View File

@@ -12,11 +12,11 @@ export interface Headers {
value: string; value: string;
} }
export type ParsedResponseHeaders = { [ headerFieldName: string ]: string }; export type ParsedResponseHeaders = { [headerFieldName: string]: string };
export type FilterFunction = { export interface FilterFunction {
name: string, name: string;
fn: (item?: FileLikeObject, options?: FileUploaderOptions) => boolean fn(this: FileUploader, item?: FileLikeObject, options?: FileUploaderOptions, queueIndex?: number): boolean | Promise<boolean>;
}; };
export interface FileUploaderOptions { export interface FileUploaderOptions {
@@ -35,7 +35,7 @@ export interface FileUploaderOptions {
disableMultipart?: boolean; disableMultipart?: boolean;
itemAlias?: string; itemAlias?: string;
authTokenHeader?: string; authTokenHeader?: string;
additionalParameter?: { [ key: string ]: any }; additionalParameter?: { [key: string]: any };
parametersBeforeFiles?: boolean; parametersBeforeFiles?: boolean;
formatDataFunction?: Function; formatDataFunction?: Function;
formatDataFunctionIsAsync?: boolean; formatDataFunctionIsAsync?: boolean;
@@ -89,35 +89,39 @@ export class FileUploader {
this.options.filters.unshift({ name: 'mimeType', fn: this._mimeTypeFilter }); this.options.filters.unshift({ name: 'mimeType', fn: this._mimeTypeFilter });
} }
for (let i = 0; i < this.queue.length; i++) { for (const q of this.queue) {
this.queue[ i ].url = this.options.url; q.url = this.options.url;
} }
} }
public addToQueue(files: File[], options?: FileUploaderOptions, filters?: FilterFunction[] | string): void { public async addToQueue(files: FileList, options?: FileUploaderOptions, filters?: FilterFunction[] | string): Promise<void> {
let list: File[] = []; let list: File[] = [];
for (let file of files) { // tslint:disable-next-line:prefer-for-of
list.push(file); for (let i = 0; i < files.length; i++) {
list.push(files[i]);
} }
let arrayOfFilters = this._getFilters(filters); let arrayOfFilters = this._getFilters(filters);
let count = this.queue.length; let count = this.queue.length;
let addedFileItems: FileItem[] = []; let addedFileItems: FileItem[] = [];
list.map((some: File) => { let idx = 0;
for (const some of list) {
if (!options) { if (!options) {
options = this.options; options = this.options;
} }
let temp = new FileLikeObject(some); let temp = new FileLikeObject(some);
if (this._isValidFile(temp, arrayOfFilters, options)) { if (await this._isValidFile(temp, arrayOfFilters, options, idx++)) {
let fileItem = new FileItem(this, some, options); let fileItem = new FileItem(this, some, options);
addedFileItems.push(fileItem); addedFileItems.push(fileItem);
this.queue.push(fileItem); this.queue.push(fileItem);
this._onAfterAddingFile(fileItem); this._onAfterAddingFile(fileItem);
} else { } else {
let filter = arrayOfFilters[ this._failFilterIndex ]; let filter = arrayOfFilters[this._failFilterIndex];
this._onWhenAddingFileFailed(temp, filter, options); this._onWhenAddingFileFailed(temp, filter, options);
} }
}); }
if (this.queue.length !== count) { if (this.queue.length !== count) {
this._onAfterAddingAll(addedFileItems); this._onAfterAddingAll(addedFileItems);
this.progress = this._getTotalProgress(); this.progress = this._getTotalProgress();
@@ -130,7 +134,7 @@ export class FileUploader {
public removeFromQueue(value: FileItem): void { public removeFromQueue(value: FileItem): void {
let index = this.getIndexOfItem(value); let index = this.getIndexOfItem(value);
let item = this.queue[ index ]; let item = this.queue[index];
if (item.isUploading) { if (item.isUploading) {
item.cancel(); item.cancel();
} }
@@ -140,26 +144,26 @@ export class FileUploader {
public clearQueue(): void { public clearQueue(): void {
while (this.queue.length) { while (this.queue.length) {
this.queue[ 0 ].remove(); this.queue[0].remove();
} }
this.progress = 0; this.progress = 0;
} }
public uploadItem(value: FileItem): void { public uploadItem(value: FileItem): void {
let index = this.getIndexOfItem(value); let index = this.getIndexOfItem(value);
let item = this.queue[ index ]; let item = this.queue[index];
let transport = this.options.isHTML5 ? '_xhrTransport' : '_iframeTransport'; let transport = this.options.isHTML5 ? '_xhrTransport' : '_iframeTransport';
item._prepareToUploading(); item._prepareToUploading();
if (this.isUploading) { if (this.isUploading) {
return; return;
} }
this.isUploading = true; this.isUploading = true;
(this as any)[ transport ](item); (this as any)[transport](item);
} }
public cancelItem(value: FileItem): void { public cancelItem(value: FileItem): void {
let index = this.getIndexOfItem(value); let index = this.getIndexOfItem(value);
let item = this.queue[ index ]; let item = this.queue[index];
let prop = this.options.isHTML5 ? item._xhr : item._form; let prop = this.options.isHTML5 ? item._xhr : item._form;
if (item && item.isUploading) { if (item && item.isUploading) {
prop.abort(); prop.abort();
@@ -172,7 +176,7 @@ export class FileUploader {
return; return;
} }
items.map((item: FileItem) => item._prepareToUploading()); items.map((item: FileItem) => item._prepareToUploading());
items[ 0 ].upload(); items[0].upload();
} }
public cancelAll(): void { public cancelAll(): void {
@@ -275,7 +279,7 @@ export class FileUploader {
public _onCompleteItem(item: FileItem, response: string, status: number, headers: ParsedResponseHeaders): void { public _onCompleteItem(item: FileItem, response: string, status: number, headers: ParsedResponseHeaders): void {
item._onComplete(response, status, headers); item._onComplete(response, status, headers);
this.onCompleteItem(item, response, status, headers); this.onCompleteItem(item, response, status, headers);
let nextItem = this.getReadyItems()[ 0 ]; let nextItem = this.getReadyItems()[0];
this.isUploading = false; this.isUploading = false;
if (nextItem) { if (nextItem) {
nextItem.upload(); nextItem.upload();
@@ -289,7 +293,7 @@ export class FileUploader {
protected _headersGetter(parsedHeaders: ParsedResponseHeaders): any { protected _headersGetter(parsedHeaders: ParsedResponseHeaders): any {
return (name: any): any => { return (name: any): any => {
if (name) { if (name) {
return parsedHeaders[ name.toLowerCase() ] || void 0; return parsedHeaders[name.toLowerCase()] || void 0;
} }
return parsedHeaders; return parsedHeaders;
}; };
@@ -316,7 +320,7 @@ export class FileUploader {
// For AWS, Additional Parameters must come BEFORE Files // For AWS, Additional Parameters must come BEFORE Files
if (this.options.additionalParameter !== undefined) { if (this.options.additionalParameter !== undefined) {
Object.keys(this.options.additionalParameter).forEach((key: string) => { Object.keys(this.options.additionalParameter).forEach((key: string) => {
let paramVal = this.options.additionalParameter[ key ]; let paramVal = this.options.additionalParameter[key];
// Allow an additional parameter to include the filename // Allow an additional parameter to include the filename
if (typeof paramVal === 'string' && paramVal.indexOf('{{file_name}}') >= 0) { if (typeof paramVal === 'string' && paramVal.indexOf('{{file_name}}') >= 0) {
paramVal = paramVal.replace('{{file_name}}', item.file.name); paramVal = paramVal.replace('{{file_name}}', item.file.name);
@@ -341,7 +345,7 @@ export class FileUploader {
let response = this._transformResponse(xhr.response, headers); let response = this._transformResponse(xhr.response, headers);
let gist = this._isSuccessCode(xhr.status) ? 'Success' : 'Error'; let gist = this._isSuccessCode(xhr.status) ? 'Success' : 'Error';
let method = '_on' + gist + 'Item'; let method = '_on' + gist + 'Item';
(this as any)[ method ](item, response, xhr.status, headers); (this as any)[method](item, response, xhr.status, headers);
this._onCompleteItem(item, response, xhr.status, headers); this._onCompleteItem(item, response, xhr.status, headers);
}; };
xhr.onerror = () => { xhr.onerror = () => {
@@ -371,11 +375,11 @@ export class FileUploader {
if (this.authToken) { if (this.authToken) {
xhr.setRequestHeader(this.authTokenHeader, this.authToken); xhr.setRequestHeader(this.authTokenHeader, this.authToken);
} }
xhr.onreadystatechange = function () { xhr.onreadystatechange = function (): void {
if (xhr.readyState == XMLHttpRequest.DONE) { if (xhr.readyState === XMLHttpRequest.DONE) {
that.response.emit(xhr.responseText) that.response.emit(xhr.responseText);
} }
} };
if (this.options.formatDataFunctionIsAsync) { if (this.options.formatDataFunctionIsAsync) {
sendable.then( sendable.then(
(result: any) => xhr.send(JSON.stringify(result)) (result: any) => xhr.send(JSON.stringify(result))
@@ -420,12 +424,18 @@ export class FileUploader {
return this.options.queueLimit === undefined || this.queue.length < this.options.queueLimit; return this.options.queueLimit === undefined || this.queue.length < this.options.queueLimit;
} }
protected _isValidFile(file: FileLikeObject, filters: FilterFunction[], options: FileUploaderOptions): boolean { protected async _isValidFile(file: FileLikeObject, filters: FilterFunction[], options: FileUploaderOptions, queueIndex: number): Promise<boolean> {
this._failFilterIndex = -1; this._failFilterIndex = -1;
return !filters.length ? true : filters.every((filter: FilterFunction) => {
for (const filter of filters) {
this._failFilterIndex++; this._failFilterIndex++;
return filter.fn.call(this, file, options);
}); if (!(await Promise.resolve(filter.fn.call(this, file, options, queueIndex)))) {
return false;
}
}
return true;
} }
protected _isSuccessCode(status: number): boolean { protected _isSuccessCode(status: number): boolean {
@@ -449,7 +459,7 @@ export class FileUploader {
key = line.slice(0, i).trim().toLowerCase(); key = line.slice(0, i).trim().toLowerCase();
val = line.slice(i + 1).trim(); val = line.slice(i + 1).trim();
if (key) { if (key) {
parsed[ key ] = parsed[ key ] ? parsed[ key ] + ', ' + val : val; parsed[key] = parsed[key] ? parsed[key] + ', ' + val : val;
} }
}); });
return parsed; return parsed;