Multiple File Select $event Object Getting Cleared from Memory #1223

New Issue

2022-08-16T16:02:07Z

krkc commented

2022-08-16 16:02:07 +00:00

(Migrated from github.com)

File list in $event object is getting cleared from memory while still in use
onFileSelected event of the ng2FileSelect directive when the "multiple" attribute is used.

Steps to reproduce:

Create html input element of type "File" and using ng2FileSelect directive along with "multiple" attribute and create handler like (onFileSelected)="selected($event)"
Run application, click input box, select one or more files
In the event handler, log the value of the $event argument to the console

Desired behavior:
FileList object shows (details collapsed) in console.
Expand FileList object in console, individual Files should show in console, length property should reflect number of files

Observed behavior:
FileList object shows (details collapsed) in console.
Expand FileList object in console, no Files exist in the FileList object. Length property is 0.

Why is this happening?:
On this line the html input "value" property is being cleared before the async .emit() event has finished what it needs to do which is causing the files in the FileList to get cleared from memory before the event handler code has finished using it.

Possible fix idea:
Make deep copy of "files" variable in the onChange() event and emit that instead.

File list in $event object is getting cleared from memory while still in use onFileSelected event of the ng2FileSelect directive when the "multiple" attribute is used. Steps to reproduce: 1. Create html input element of type "File" and using ng2FileSelect directive along with "multiple" attribute and create handler like (onFileSelected)="selected($event)" 2. Run application, click input box, select one or more files 3. In the event handler, log the value of the $event argument to the console Desired behavior: FileList object shows (details collapsed) in console. Expand FileList object in console, individual Files should show in console, length property should reflect number of files Observed behavior: FileList object shows (details collapsed) in console. Expand FileList object in console, no Files exist in the FileList object. Length property is 0. Why is this happening?: [On this line](https://github.com/valor-software/ng2-file-upload/blob/6608960cecd9f800aae27d8d4f4a21c418a3828a/libs/ng2-file-upload/file-upload/file-select.directive.ts#L38) the html input "value" property is being cleared before the async .emit() event has finished what it needs to do which is causing the files in the FileList to get cleared from memory before the event handler code has finished using it. Possible fix idea: Make deep copy of "files" variable in the onChange() event and emit that instead.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#1223