dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

Upgrade to angular 2.0.0-rc.1 #176

Merged
ciriarte merged 6 commits from master into master 2016-05-07 16:39:03 +00:00
Conversation 9 Commits 6 Files Changed 11 +76 -39
ciriarte commented 2016-05-03 23:43:43 +00:00 (Migrated from github.com)
Copy Link

Hi Guys,

I've updated the code to point to 2.0.0-rc.1, please let me know if it looks OK or you want me to change anything.

Hi Guys, I've updated the code to point to 2.0.0-rc.1, please let me know if it looks OK or you want me to change anything.
👍 1
ciriarte commented 2016-05-06 22:28:19 +00:00 (Migrated from github.com)
Copy Link

@valorkin sorry to bother you again! I've updated this one as well to rc.1 and made Travis happy-green. Could you please take a look whenever you have the chance? Good luck at ngconf!

@valorkin sorry to bother you again! I've updated this one as well to rc.1 and made Travis happy-green. Could you please take a look whenever you have the chance? Good luck at ngconf!
ciriarte commented 2016-05-06 22:29:00 +00:00 (Migrated from github.com)
Copy Link

@heidermatos I think it needs a bit more testing, but it looks OK to me so far.

@heidermatos I think it needs a bit more testing, but it looks OK to me so far.
valorkin commented 2016-05-07 00:35:17 +00:00 (Migrated from github.com)
Copy Link

@ciriarte you can bother me with such PR's as much as you can :)

@ciriarte you can bother me with such PR's as much as you can :)
valorkin commented 2016-05-07 00:40:56 +00:00 (Migrated from github.com)
Copy Link

looks good, with some comments :)

looks good, with some comments :)
ciriarte commented 2016-05-07 05:18:57 +00:00 (Migrated from github.com)
Copy Link

@valorkin Thanks for the feedback! I've applied the changes you've requested. My only concern is the following npm warning that appears due to the shift to dev dep of rxjs:

npm WARN @angular/core@2.0.0-rc.1 requires a peer of rxjs@5.0.0-beta.6 but none was installed.

I guess we should leave it to the user to declare those dependencies in their project.json, according to this commit:

80b025ae53

Therefore, I've decided to just instruct Travis to install rxjs during build time.

@valorkin Thanks for the feedback! I've applied the changes you've requested. My only concern is the following npm warning that appears due to the shift to dev dep of rxjs: `npm WARN @angular/core@2.0.0-rc.1 requires a peer of rxjs@5.0.0-beta.6 but none was installed.` I guess we should leave it to the user to declare those dependencies in their project.json, according to this commit: https://github.com/angular/angular/commit/80b025ae53760310e6776dd7897eff4bda5e4a26 Therefore, I've decided to just instruct Travis to install rxjs during build time.
ciriarte commented 2016-05-07 14:45:20 +00:00 (Migrated from github.com)
Copy Link

@valorkin done 👍 it did speed up the build a lot! I've removed 4 as well. Thanks for your feedback, I'm learning a lot.

@valorkin done 👍 it did speed up the build a lot! I've removed 4 as well. Thanks for your feedback, I'm learning a lot.
rodolfocop commented 2016-05-08 15:04:44 +00:00 (Migrated from github.com)
Copy Link

very good man, I thank the commitment of all to finalize these modifications!

very good man, I thank the commitment of all to finalize these modifications!
valorkin commented 2016-05-09 06:17:47 +00:00 (Migrated from github.com)
Copy Link

Hey, guys I am flying back, tomorrow I should be able to test and merge

On Sun, May 8, 2016, 17:04 Rodolfo Galli notifications@github.com wrote:

very good man, I thank the commitment of all to finalize these
modifications!

—
You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub
https://github.com/valor-software/ng2-file-upload/pull/176#issuecomment-217725561

Hey, guys I am flying back, tomorrow I should be able to test and merge On Sun, May 8, 2016, 17:04 Rodolfo Galli notifications@github.com wrote: > very good man, I thank the commitment of all to finalize these > modifications! > > — > You are receiving this because you modified the open/close state. > > Reply to this email directly or view it on GitHub > https://github.com/valor-software/ng2-file-upload/pull/176#issuecomment-217725561
rodolfocop commented 2016-05-09 13:56:58 +00:00 (Migrated from github.com)
Copy Link

No problem, i'll be waiting and if you need to be here to help!

No problem, i'll be waiting and if you need to be here to help!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
allan medjedovic root sabhas
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#176
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?