dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

Update to rc5 #344

New Issue
Closed
opened 2016-08-11 12:42:26 +00:00 by TeaTimeForever · 5 comments
TeaTimeForever commented 2016-08-11 12:42:26 +00:00 (Migrated from github.com)
Copy Link

The rc5 introduces the concept of module (@NgModule).

npm ERR! peerinvalid Peer ng2-file-upload@1.0.3 wants @angular/common@^2.0.0-rc.1

The rc5 introduces the concept of module (@NgModule). npm ERR! peerinvalid Peer ng2-file-upload@1.0.3 wants @angular/common@^2.0.0-rc.1
👍 6
Dinistro commented 2016-08-11 12:59:42 +00:00 (Migrated from github.com)
Copy Link

@eques I looks like you messed up something in your package.json. Can you please show it?

@eques I looks like you messed up something in your `package.json`. Can you please show it?
rashmidixit commented 2016-08-16 05:13:23 +00:00 (Migrated from github.com)
Copy Link

I am getting the same error. Can you please update ng2-file-upload to use common-rc5?

I am getting the same error. Can you please update ng2-file-upload to use common-rc5?
👍 2
bautistaaa commented 2016-08-27 17:17:22 +00:00 (Migrated from github.com)
Copy Link

im using rc5 just fine with this

im using rc5 just fine with this
KyleCartmell commented 2016-08-31 17:20:23 +00:00 (Migrated from github.com)
Copy Link

@eques @rashmidixit The dependency declaration includes a caret so it will accept 2.0.0-rc.5. I have a project that combines ng2-file-upload 1.0.3 with rc5 without any peer dependency errors. So does bautistaaa. Looking at the history of package.json it seems like there isn't a release of ng2-file-upload since the ng2 beta that lacked the minor release tolerant dependency declaration. This error would seem to indicate that angular is actually missing. You're npm installed, right? How is angular 2 declared in your package.json? What is in node_modules/@angular? Are you seeing any other dependency errors?

But, the rc5 update is probably a thing. Not because of this error message, but because there have been so many breaking changes and deprecations between rc5 and rc1 AND rc6 is supposed to break all the rc5 deprecations.

@eques @rashmidixit The dependency declaration includes a caret so it will accept 2.0.0-rc.5. I have a project that combines ng2-file-upload 1.0.3 with rc5 without any peer dependency errors. So does bautistaaa. Looking at the history of package.json it seems like there isn't a release of ng2-file-upload since the ng2 beta that lacked the minor release tolerant dependency declaration. This error would seem to indicate that angular is actually missing. You're npm installed, right? How is angular 2 declared in your package.json? What is in node_modules/@angular? Are you seeing any other dependency errors? But, the rc5 update is probably a thing. Not because of this error message, but because there have been so many breaking changes and deprecations between rc5 and rc1 AND rc6 is supposed to break all the rc5 deprecations.
adrianfaciu commented 2016-09-07 06:45:53 +00:00 (Migrated from github.com)
Copy Link

Will have a look and try to make a pull request this week with RC.6 update.

Will have a look and try to make a pull request this week with RC.6 update.
👍 3
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
allan medjedovic root sabhas
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#344
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?