dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

Update angular peer dependencies to 2.0.1 #415

New Issue
Open
opened 2016-09-26 09:18:59 +00:00 by VadimDez · 4 comments
VadimDez commented 2016-09-26 09:18:59 +00:00 (Migrated from github.com)
Copy Link
npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/common@2.0.0 but none was installed.
npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/compiler@2.0.0 but none was installed.
npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/core@2.0.0 but none was installed.
npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/forms@2.0.0 but none was installed.
``` npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/common@2.0.0 but none was installed. npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/compiler@2.0.0 but none was installed. npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/core@2.0.0 but none was installed. npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/forms@2.0.0 but none was installed. ```
👍 14
zleao commented 2016-09-29 13:10:29 +00:00 (Migrated from github.com)
Copy Link

Had the same problem.
You could also just define the peerDependencies as "2.0.x" or "2.x"
Do you see any inconvenience?

Had the same problem. You could also just define the peerDependencies as "2.0.x" or "2.x" Do you see any inconvenience?
sylvainpolletvillard commented 2016-10-12 08:41:02 +00:00 (Migrated from github.com)
Copy Link

This has been fixed with 3fec3850b4 but it is not published on NPM yet.

@valorkin can you publish a new version to NPM please ?

This has been fixed with https://github.com/valor-software/ng2-file-upload/commit/3fec3850b463b0efb4d8836c3899729fd3ad6a29 but it is not published on NPM yet. @valorkin can you publish a new version to NPM please ?
valorkin commented 2016-10-12 08:51:31 +00:00 (Migrated from github.com)
Copy Link

ok, doing it right

ok, doing it right
👍 2 😕 1
HankBrown commented 2016-10-14 12:45:44 +00:00 (Migrated from github.com)
Copy Link
book15:ng2-file-upload hank$ npm i ng2-file-upload --save
npm WARN saveError ENOENT: no such file or directory, open '/Users/hank/home/hank/js/ng2-file-upload/package.json'
npm WARN enoent ENOENT: no such file or directory, open '/Users/hank/home/hank/js/ng2-file-upload/package.json'
npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/common@2.0.0 but none was installed.
npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/compiler@2.0.0 but none was installed.
npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/core@2.0.0 but none was installed.
npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/forms@2.0.0 but none was installed.

Edited /ng2-file-upload/node_modules/ng2-file-upload/package.json, tried...

    "@angular/common": "2.x",
    "@angular/compiler": "2.x",
    "@angular/core": "2.x",
    "@angular/forms": "2.x",

    "@angular/common": "~2.0.1",
    "@angular/compiler": "~2.0.1",
    "@angular/core": "~2.0.1",
    "@angular/forms": "~2.0.1",

Alas no joy. Looks like this is maybe some kind of issue with Angular2....

https://github.com/angular/angular/issues/8913
https://github.com/angular/angular/issues/5746

On the other hand, their "Quick Start" says you can ignore npm WARN.
So now I think the problem for me is that your demo is not wrapped into an angular2 project with a pretty bow... Jeez, do I have to learn everything ;)

``` book15:ng2-file-upload hank$ npm i ng2-file-upload --save npm WARN saveError ENOENT: no such file or directory, open '/Users/hank/home/hank/js/ng2-file-upload/package.json' npm WARN enoent ENOENT: no such file or directory, open '/Users/hank/home/hank/js/ng2-file-upload/package.json' npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/common@2.0.0 but none was installed. npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/compiler@2.0.0 but none was installed. npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/core@2.0.0 but none was installed. npm WARN ng2-file-upload@1.1.0 requires a peer of @angular/forms@2.0.0 but none was installed. ``` Edited /ng2-file-upload/node_modules/ng2-file-upload/package.json, tried... ``` "@angular/common": "2.x", "@angular/compiler": "2.x", "@angular/core": "2.x", "@angular/forms": "2.x", ``` ``` "@angular/common": "~2.0.1", "@angular/compiler": "~2.0.1", "@angular/core": "~2.0.1", "@angular/forms": "~2.0.1", ``` Alas no joy. Looks like this is maybe some kind of issue with Angular2.... https://github.com/angular/angular/issues/8913 https://github.com/angular/angular/issues/5746 On the other hand, their "Quick Start" says you can ignore npm WARN. So now I think the problem for me is that your demo is not wrapped into an angular2 project with a pretty bow... Jeez, do I have to learn everything ;)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
allan medjedovic root sabhas
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#415
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?