Adds some Fixes for AWS Support. #658

2017-03-06T22:34:42Z

kopertop commented

2017-03-06 22:34:42 +00:00

(Migrated from github.com)

AWS Requires any additional parameters to be specified BEFORE Files.
This also adds the ability to specify a {{file_name}} template in any
additional parameters to allow adding the filename to additional
parameters.

For example, you can now specify:

additionalParameter: {
key: "path/to/uploads/{{file_name}}"
}

AWS Requires any additional parameters to be specified BEFORE Files. This also adds the ability to specify a {{file_name}} template in any additional parameters to allow adding the filename to additional parameters. For example, you can now specify: additionalParameter: { key: "path/to/uploads/{{file_name}}" }

codecov-io commented

2017-03-06 22:42:52 +00:00

(Migrated from github.com)

Codecov Report

Merging #658 into development will increase coverage by 17.54%.
The diff coverage is 0%.

@@               Coverage Diff                @@
##           development     #658       +/-   ##
================================================
+ Coverage        33.08%   50.63%   +17.54%     
================================================
  Files               10       10               
  Lines              547      551        +4     
  Branches            70       75        +5     
================================================
+ Hits               181      279       +98     
+ Misses             363      270       -93     
+ Partials             3        2        -1

Impacted Files	Coverage Δ
src/file-upload/file-uploader.class.ts	`40.14% <0%> (+14.96%)`	⬆️
src/file-upload/file-item.class.ts	`27.27% <0%> (+5.05%)`	⬆️
scripts/matchers.ts	`57.14% <0%> (+14.28%)`	⬆️
src/file-upload/file-like-object.class.ts	`47.36% <0%> (+15.78%)`	⬆️
src/file-upload/file-type.class.ts	`53.84% <0%> (+30.76%)`	⬆️
src/file-upload/file-select.directive.ts	`95.45% <0%> (+40.9%)`	⬆️
src/file-upload/file-drop.directive.ts	`87.03% <0%> (+49.3%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c8303...a333c59. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=h1) Report > Merging [#658](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/99c83035d1234be175cb533375194572caef3e5e?src=pr&el=desc) will **increase** coverage by `17.54%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658/graphs/tree.svg?token=P8ngsZQolN&width=650&height=150&src=pr)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #658 +/- ## ================================================ + Coverage 33.08% 50.63% +17.54% ================================================ Files 10 10 Lines 547 551 +4 Branches 70 75 +5 ================================================ + Hits 181 279 +98 + Misses 363 270 -93 + Partials 3 2 -1 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-uploader.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdXBsb2FkZXIuY2xhc3MudHM=) | `40.14% <0%> (+14.96%)` | :arrow_up: | | [src/file-upload/file-item.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtaXRlbS5jbGFzcy50cw==) | `27.27% <0%> (+5.05%)` | :arrow_up: | | [scripts/matchers.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree#diff-c2NyaXB0cy9tYXRjaGVycy50cw==) | `57.14% <0%> (+14.28%)` | :arrow_up: | | [src/file-upload/file-like-object.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtbGlrZS1vYmplY3QuY2xhc3MudHM=) | `47.36% <0%> (+15.78%)` | :arrow_up: | | [src/file-upload/file-type.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdHlwZS5jbGFzcy50cw==) | `53.84% <0%> (+30.76%)` | :arrow_up: | | [src/file-upload/file-select.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtc2VsZWN0LmRpcmVjdGl2ZS50cw==) | `95.45% <0%> (+40.9%)` | :arrow_up: | | [src/file-upload/file-drop.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtZHJvcC5kaXJlY3RpdmUudHM=) | `87.03% <0%> (+49.3%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=footer). Last update [99c8303...a333c59](https://codecov.io/gh/valor-software/ng2-file-upload/pull/658?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#658