Adding some tests #898

2017-10-01T10:58:06Z

adrianfaciu commented

2017-10-01 10:58:06 +00:00

(Migrated from github.com)

Included changes:

adding some tests for the two existing directives
fixed karma config

Will work on a different PR to try to rename this to ngx-file-upload.

Included changes: - adding some tests for the two existing directives - fixed karma config Will work on a different PR to try to rename this to ngx-file-upload.

valorkin (Migrated from github.com) reviewed 2017-10-01 10:58:06 +00:00

codecov[bot] commented

2017-10-01 14:13:45 +00:00

(Migrated from github.com)

Codecov Report

Merging #898 into development will increase coverage by 3.24%.
The diff coverage is 66.66%.

@@               Coverage Diff               @@
##           development     #898      +/-   ##
===============================================
+ Coverage        32.22%   35.47%   +3.24%     
===============================================
  Files               10       10              
  Lines              540      530      -10     
  Branches            70       74       +4     
===============================================
+ Hits               174      188      +14     
+ Misses             363      325      -38     
- Partials             3       17      +14

Impacted Files	Coverage Δ
src/file-upload/file-drop.directive.ts	`61.22% <64.28%> (+28.57%)`	⬆️
src/file-upload/file-select.directive.ts	`80% <71.42%> (+30%)`	⬆️
scripts/matchers.ts	`33.33% <0%> (-9.53%)`	⬇️
src/file-upload/file-like-object.class.ts	`23.52% <0%> (-8.05%)`	⬇️
src/file-upload/file-item.class.ts	`21.42% <0%> (-0.8%)`	⬇️
src/file-upload/file-uploader.class.ts	`25% <0%> (-0.19%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41759be...048f534. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=h1) Report > Merging [#898](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/41759be974625bc9821ea87860d7828505bca9f3?src=pr&el=desc) will **increase** coverage by `3.24%`. > The diff coverage is `66.66%`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898/graphs/tree.svg?width=650&token=P8ngsZQolN&height=150&src=pr)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #898 +/- ## =============================================== + Coverage 32.22% 35.47% +3.24% =============================================== Files 10 10 Lines 540 530 -10 Branches 70 74 +4 =============================================== + Hits 174 188 +14 + Misses 363 325 -38 - Partials 3 17 +14 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-drop.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtZHJvcC5kaXJlY3RpdmUudHM=) | `61.22% <64.28%> (+28.57%)` | :arrow_up: | | [src/file-upload/file-select.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtc2VsZWN0LmRpcmVjdGl2ZS50cw==) | `80% <71.42%> (+30%)` | :arrow_up: | | [scripts/matchers.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=tree#diff-c2NyaXB0cy9tYXRjaGVycy50cw==) | `33.33% <0%> (-9.53%)` | :arrow_down: | | [src/file-upload/file-like-object.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtbGlrZS1vYmplY3QuY2xhc3MudHM=) | `23.52% <0%> (-8.05%)` | :arrow_down: | | [src/file-upload/file-item.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtaXRlbS5jbGFzcy50cw==) | `21.42% <0%> (-0.8%)` | :arrow_down: | | [src/file-upload/file-uploader.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdXBsb2FkZXIuY2xhc3MudHM=) | `25% <0%> (-0.19%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=footer). Last update [41759be...048f534](https://codecov.io/gh/valor-software/ng2-file-upload/pull/898?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#898