Add response and function to modify the request body #901

Merged
davidmds merged 5 commits from development into development 2017-10-07 08:48:48 +00:00
davidmds commented 2017-10-04 21:44:06 +00:00 (Migrated from github.com)

Included changes:

  • added response property
  • added property to define function to modify the request body
Included changes: - added response property - added property to define function to modify the request body
codecov[bot] commented 2017-10-04 21:50:05 +00:00 (Migrated from github.com)

Codecov Report

Merging #901 into development will decrease coverage by 0.28%.
The diff coverage is 16.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #901      +/-   ##
===============================================
- Coverage        35.47%   35.18%   -0.29%     
===============================================
  Files               10       10              
  Lines              530      540      +10     
  Branches            74       76       +2     
===============================================
+ Hits               188      190       +2     
- Misses             325      333       +8     
  Partials            17       17
Impacted Files Coverage Δ
src/file-upload/file-uploader.class.ts 24.81% <16.66%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df3c5f...be7f164. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901?src=pr&el=h1) Report > Merging [#901](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/5df3c5f0765f0de10ba216ab3bc722dd96381f54?src=pr&el=desc) will **decrease** coverage by `0.28%`. > The diff coverage is `16.66%`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901/graphs/tree.svg?width=650&height=150&src=pr&token=P8ngsZQolN)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #901 +/- ## =============================================== - Coverage 35.47% 35.18% -0.29% =============================================== Files 10 10 Lines 530 540 +10 Branches 74 76 +2 =============================================== + Hits 188 190 +2 - Misses 325 333 +8 Partials 17 17 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-uploader.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdXBsb2FkZXIuY2xhc3MudHM=) | `24.81% <16.66%> (-0.19%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901?src=pr&el=footer). Last update [5df3c5f...be7f164](https://codecov.io/gh/valor-software/ng2-file-upload/pull/901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
adrianfaciu commented 2017-10-05 06:54:19 +00:00 (Migrated from github.com)

Awesome, thanks for this 👍. Can you please also update the demo app with a sample for this, so it's easier for people to use.

Awesome, thanks for this 👍. Can you please also update the demo app with a sample for this, so it's easier for people to use.
davidmds commented 2017-10-06 20:42:33 +00:00 (Migrated from github.com)

@adrianfaciu I added in the example

@adrianfaciu I added in the example
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#901