dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

Update: setOptions #904

Merged
guanbo merged 1 commits from options into development 2017-10-22 10:03:45 +00:00
Conversation 2 Commits 1 Files Changed 1 +3 -3
guanbo commented 2017-10-09 09:43:55 +00:00 (Migrated from github.com)
Copy Link

prevent from overwrite options which set before, such as authToken

prevent from overwrite options which set before, such as authToken
codecov[bot] commented 2017-10-09 09:50:13 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #904 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #904   +/-   ##
============================================
  Coverage        34.72%   34.72%           
============================================
  Files               10       10           
  Lines              550      550           
  Branches            80       80           
============================================
  Hits               191      191           
  Misses             341      341           
  Partials            18       18
Impacted Files Coverage Δ
src/file-upload/file-uploader.class.ts 24.18% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa14483...ccee135. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904?src=pr&el=h1) Report > Merging [#904](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/aa1448392b257bb1bf5306800ad1580f2797d0d5?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904/graphs/tree.svg?token=P8ngsZQolN&src=pr&width=650&height=150)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #904 +/- ## ============================================ Coverage 34.72% 34.72% ============================================ Files 10 10 Lines 550 550 Branches 80 80 ============================================ Hits 191 191 Misses 341 341 Partials 18 18 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-uploader.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdXBsb2FkZXIuY2xhc3MudHM=) | `24.18% <100%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904?src=pr&el=footer). Last update [aa14483...ccee135](https://codecov.io/gh/valor-software/ng2-file-upload/pull/904?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
adrianfaciu commented 2017-10-22 10:03:49 +00:00 (Migrated from github.com)
Copy Link

Thanks.

Thanks.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
allan medjedovic root sabhas
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#904
Delete Branch "options"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?