Multi-upload in a single request #993

2018-03-17T16:05:50Z

koenvanderlinden commented

2018-03-17 16:05:50 +00:00

(Migrated from github.com)

Feature to upload all files using one multipart request.

Let me know what you think of it.

Feature to upload all files using one multipart request. Let me know what you think of it.

codecov[bot] commented

2018-03-17 16:12:41 +00:00

(Migrated from github.com)

Codecov Report

Merging #993 into development will decrease coverage by 0.86%.
The diff coverage is 10.34%.

@@               Coverage Diff               @@
##           development     #993      +/-   ##
===============================================
- Coverage        34.72%   33.85%   -0.87%     
===============================================
  Files               10       10              
  Lines              550      570      +20     
  Branches            80       81       +1     
===============================================
+ Hits               191      193       +2     
- Misses             341      359      +18     
  Partials            18       18

Impacted Files	Coverage Δ
src/file-upload/file-uploader.class.ts	`23.23% <10.34%> (-0.96%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb48f44...95d5778. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993?src=pr&el=h1) Report > Merging [#993](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/fb48f4411d163a4219ffae12bfa24ce7f803e837?src=pr&el=desc) will **decrease** coverage by `0.86%`. > The diff coverage is `10.34%`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993/graphs/tree.svg?height=150&width=650&token=P8ngsZQolN&src=pr)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #993 +/- ## =============================================== - Coverage 34.72% 33.85% -0.87% =============================================== Files 10 10 Lines 550 570 +20 Branches 80 81 +1 =============================================== + Hits 191 193 +2 - Misses 341 359 +18 Partials 18 18 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-uploader.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993/diff?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdXBsb2FkZXIuY2xhc3MudHM=) | `23.23% <10.34%> (-0.96%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993?src=pr&el=footer). Last update [fb48f44...95d5778](https://codecov.io/gh/valor-software/ng2-file-upload/pull/993?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

adrianfaciu commented

2018-03-20 07:19:27 +00:00

(Migrated from github.com)

I just had a quick view, not much free time for me right now, but it looks good.
However most people (me included) use this library with AOT so we kind of need to make it work with that.

As a tip, you could use git rebase to squash the commits together.

Maybe @valorkin or @buchslava can provide more assistance.

I just had a quick view, not much free time for me right now, but it looks good. However most people (me included) use this library with AOT so we kind of need to make it work with that. As a tip, you could use git rebase to squash the commits together. Maybe @valorkin or @buchslava can provide more assistance.

koenvanderlinden commented

2018-03-20 08:01:38 +00:00

(Migrated from github.com)

Thanks for having a look and some tips.
About the AOT. The original sourcecode gave me the same errors, so the changes in this Pull are not the root-cause of my build failing with AOT.
I case someone has some spare time, the --aot param can be added again to see what happens.

Thanks for having a look and some tips. About the AOT. The original sourcecode gave me the same errors, so the changes in this Pull are not the root-cause of my build failing with AOT. I case someone has some spare time, the --aot param can be added again to see what happens.

ar27111994 commented

2019-01-19 13:25:16 +00:00

(Migrated from github.com)

When will this get merged?

👍 1

eikishi01 commented

2019-02-11 14:08:38 +00:00

(Migrated from github.com)

I was just looking for a way to upload all files individually and I got to this PR finding out that it is the default behaviour, which is what I needed, @koenvanderlinden does you PR consider allowing the use of both approaches? both use cases are valid and it should count for them.

This pull request has changes conflicting with the target branch.

package.json
package-lock.json

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin koenvanderlinden/multiupload-singlepost:koenvanderlinden/multiupload-singlepost

git checkout koenvanderlinden/multiupload-singlepost

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#993