From 00a99e752c3b96c162647000307911fac1fd1be9 Mon Sep 17 00:00:00 2001 From: Sabir Hassan Date: Thu, 10 Mar 2022 15:44:38 +0500 Subject: [PATCH 1/2] fix: no need to stringify res/err in sas9JobExecutor before appending request #675 --- src/job-execution/Sas9JobExecutor.ts | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/src/job-execution/Sas9JobExecutor.ts b/src/job-execution/Sas9JobExecutor.ts index b1c1fd0..7529914 100644 --- a/src/job-execution/Sas9JobExecutor.ts +++ b/src/job-execution/Sas9JobExecutor.ts @@ -85,25 +85,11 @@ export class Sas9JobExecutor extends BaseJobExecutor { } ) .then((res: any) => { - let resString = res - - if (typeof res === 'object') { - resString = JSON.stringify(res) - } - - this.requestClient!.appendRequest(resString, sasJob, config.debug) - + this.requestClient!.appendRequest(res, sasJob, config.debug) return res }) .catch((err: any) => { - let errString = err - - if (typeof err === 'object') { - errString = JSON.stringify(errString) - } - - this.requestClient!.appendRequest(errString, sasJob, config.debug) - + this.requestClient!.appendRequest(err, sasJob, config.debug) return err }) } From e92d0d73b5e722e81cf1de6417bbfe706358a037 Mon Sep 17 00:00:00 2001 From: Sabir Hassan Date: Thu, 10 Mar 2022 16:17:09 +0500 Subject: [PATCH 2/2] chore: add comments --- src/job-execution/Sas9JobExecutor.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/job-execution/Sas9JobExecutor.ts b/src/job-execution/Sas9JobExecutor.ts index 7529914..2c866e2 100644 --- a/src/job-execution/Sas9JobExecutor.ts +++ b/src/job-execution/Sas9JobExecutor.ts @@ -85,10 +85,12 @@ export class Sas9JobExecutor extends BaseJobExecutor { } ) .then((res: any) => { + //appending response to requests array that will be used for requests history reference this.requestClient!.appendRequest(res, sasJob, config.debug) return res }) .catch((err: any) => { + //appending error to requests array that will be used for requests history reference this.requestClient!.appendRequest(err, sasJob, config.debug) return err })