chore(lint): fixed linting issues

src/api/viya/executeScript.ts

@@ -55,24 +55,25 @@ export async function executeScript(
   try {
     let executionSessionId: string
 
-    const session = await sessionManager
-      .getSession(access_token)
-      .catch((err) => {
-        throw prefixMessage(err, 'Error while getting session. ')
-      })
+    const session = await sessionManager.getSession(access_token).catch(err => {
+      throw prefixMessage(err, 'Error while getting session. ')
+    })
 
     executionSessionId = session!.id
 
     if (printPid) {
       const { result: jobIdVariable } = await sessionManager
         .getVariable(executionSessionId, 'SYSJOBID', access_token)
-        .catch((err) => {
+        .catch(err => {
           throw prefixMessage(err, 'Error while getting session variable. ')
         })
 
       if (jobIdVariable && jobIdVariable.value) {
         const relativeJobPath = rootFolderName
-          ? jobPath.split(rootFolderName).join('').replace(/^\//, '')
+          ? jobPath
+              .split(rootFolderName)
+              .join('')
+              .replace(/^\//, '')
           : jobPath
 
         const logger = process.logger || console
@@ -126,7 +127,7 @@ export async function executeScript(
     if (data) {
       if (JSON.stringify(data).includes(';')) {
         files = await uploadTables(requestClient, data, access_token).catch(
-          (err) => {
+          err => {
             throw prefixMessage(err, 'Error while uploading tables. ')
           }
         )
@@ -159,7 +160,7 @@ export async function executeScript(
         jobRequestBody,
         access_token
       )
-      .catch((err) => {
+      .catch(err => {
         throw prefixMessage(err, 'Error while posting job. ')
       })
 
@@ -180,7 +181,7 @@ export async function executeScript(
       debug,
       authConfig,
       pollOptions
-    ).catch(async (err) => {
+    ).catch(async err => {
       const error = err?.response?.data
       const result = /err=[0-9]*,/.exec(error)
 
@@ -208,14 +209,14 @@ export async function executeScript(
         `/compute/sessions/${executionSessionId}/jobs/${postedJob.id}`,
         access_token
       )
-      .catch((err) => {
+      .catch(err => {
         throw prefixMessage(err, 'Error while getting job. ')
       })
 
     let jobResult
     let log = ''
 
-    const logLink = currentJob.links.find((l) => l.rel === 'log')
+    const logLink = currentJob.links.find(l => l.rel === 'log')
 
     if (debug && logLink) {
       const logUrl = `${logLink.href}/content`
@@ -240,7 +241,7 @@ export async function executeScript(
 
     jobResult = await requestClient
       .get<any>(resultLink, access_token, 'text/plain')
-      .catch(async (e) => {
+      .catch(async e => {
         if (e instanceof NotFoundError) {
           if (logLink) {
             const logUrl = `${logLink.href}/content`
@@ -266,7 +267,7 @@ export async function executeScript(
 
     await sessionManager
       .clearSession(executionSessionId, access_token)
-      .catch((err) => {
+      .catch(err => {
         throw prefixMessage(err, 'Error while clearing session. ')
       })
 

src/api/viya/pollJobState.ts

@@ -37,7 +37,7 @@ export async function pollJobState(
     '',
     debug,
     authConfig
-  ).catch((err) => {
+  ).catch(err => {
     logger.error(
       `Error fetching job state from ${stateLink.href}. Starting poll, assuming job to be running.`,
       err
@@ -139,7 +139,7 @@ const getJobState = async (
         {},
         debug
       )
-      .catch((err) => {
+      .catch(err => {
         throw new JobStatePollError(job.id, err)
       })
 
@@ -192,7 +192,7 @@ const doPoll = async (
       state,
       debug,
       authConfig
-    ).catch((err) => {
+    ).catch(err => {
       errorCount++
       if (pollCount >= maxPollCount || errorCount >= maxErrorCount) {
         throw err

src/api/viya/saveLog.ts

@@ -36,7 +36,7 @@ export async function saveLog(
   }
 
   const logger = process.logger || console
-  const jobLogUrl = job.links.find((l) => l.rel === 'log')
+  const jobLogUrl = job.links.find(l => l.rel === 'log')
 
   if (!jobLogUrl) {
     throw new Error(`Log URL for job ${job.id} was not found.`)

src/api/viya/spec/executeScript.spec.ts

@@ -80,7 +80,7 @@ describe('executeScript', () => {
       'test',
       ['%put hello'],
       'test context'
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(error).toContain('Error while getting session.')
   })
@@ -128,7 +128,7 @@ describe('executeScript', () => {
       false,
       defaultPollOptions,
       true
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(error).toContain('Error while getting session variable.')
   })
@@ -297,7 +297,7 @@ describe('executeScript', () => {
       false,
       defaultPollOptions,
       true
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(error).toContain('Error while posting job')
   })
@@ -367,7 +367,7 @@ describe('executeScript', () => {
       true,
       defaultPollOptions,
       true
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(error).toContain('Error while polling job status.')
   })
@@ -393,12 +393,12 @@ describe('executeScript', () => {
       true,
       defaultPollOptions,
       true
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(fetchLogsModule.fetchLogByChunks).toHaveBeenCalledWith(
       requestClient,
       mockAuthConfig.access_token,
-      mockJob.links.find((l) => l.rel === 'up')!.href + '/log',
+      mockJob.links.find(l => l.rel === 'up')!.href + '/log',
       1000000
     )
     expect(error.log).toEqual('Test Log')
@@ -424,7 +424,7 @@ describe('executeScript', () => {
     expect(fetchLogsModule.fetchLogByChunks).toHaveBeenCalledWith(
       requestClient,
       mockAuthConfig.access_token,
-      mockJob.links.find((l) => l.rel === 'log')!.href + '/content',
+      mockJob.links.find(l => l.rel === 'log')!.href + '/content',
       mockJob.logStatistics.lineCount
     )
   })
@@ -468,12 +468,12 @@ describe('executeScript', () => {
       true,
       defaultPollOptions,
       true
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(fetchLogsModule.fetchLogByChunks).toHaveBeenCalledWith(
       requestClient,
       mockAuthConfig.access_token,
-      mockJob.links.find((l) => l.rel === 'log')!.href + '/content',
+      mockJob.links.find(l => l.rel === 'log')!.href + '/content',
       mockJob.logStatistics.lineCount
     )
 
@@ -501,12 +501,12 @@ describe('executeScript', () => {
       true,
       defaultPollOptions,
       true
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(fetchLogsModule.fetchLogByChunks).toHaveBeenCalledWith(
       requestClient,
       mockAuthConfig.access_token,
-      mockJob.links.find((l) => l.rel === 'log')!.href + '/content',
+      mockJob.links.find(l => l.rel === 'log')!.href + '/content',
       mockJob.logStatistics.lineCount
     )
 
@@ -561,7 +561,7 @@ describe('executeScript', () => {
       true,
       defaultPollOptions,
       true
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(requestClient.get).toHaveBeenCalledWith(
       `/compute/sessions/${mockSession.id}/filerefs/_webout/content`,
@@ -572,7 +572,7 @@ describe('executeScript', () => {
     expect(fetchLogsModule.fetchLogByChunks).toHaveBeenCalledWith(
       requestClient,
       mockAuthConfig.access_token,
-      mockJob.links.find((l) => l.rel === 'log')!.href + '/content',
+      mockJob.links.find(l => l.rel === 'log')!.href + '/content',
       mockJob.logStatistics.lineCount
     )
 
@@ -622,7 +622,7 @@ describe('executeScript', () => {
       true,
       defaultPollOptions,
       true
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(error).toContain('Error while clearing session.')
   })

src/api/viya/spec/getFileStream.spec.ts

@@ -37,5 +37,5 @@ const setupMocks = () => {
   jest.mock('@sasjs/utils/file/file')
   jest
     .spyOn(fileModule, 'createWriteStream')
-    .mockImplementation(() => Promise.resolve({} as unknown as WriteStream))
+    .mockImplementation(() => Promise.resolve(({} as unknown) as WriteStream))
 }

src/api/viya/spec/pollJobState.spec.ts

@@ -55,11 +55,11 @@ describe('pollJobState', () => {
   it('should throw an error if the job does not have a state link', async () => {
     const error = await pollJobState(
       requestClient,
-      { ...mockJob, links: mockJob.links.filter((l) => l.rel !== 'state') },
+      { ...mockJob, links: mockJob.links.filter(l => l.rel !== 'state') },
       false,
       undefined,
       defaultPollOptions
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect((error as Error).message).toContain('Job state link was not found.')
   })
@@ -238,7 +238,7 @@ describe('pollJobState', () => {
       false,
       undefined,
       defaultPollOptions
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(error.message).toEqual(
       'Error while polling job state for job j0b: Status Error'
@@ -267,13 +267,13 @@ const setupMocks = () => {
     .mockImplementation(() => Promise.resolve())
   jest
     .spyOn(getFileStreamModule, 'getFileStream')
-    .mockImplementation(() => Promise.resolve({} as unknown as WriteStream))
+    .mockImplementation(() => Promise.resolve(({} as unknown) as WriteStream))
   jest.spyOn(isNodeModule, 'isNode').mockImplementation(() => true)
 }
 
 const mockSimplePoll = (runningCount = 2) => {
   let count = 0
-  jest.spyOn(requestClient, 'get').mockImplementation((url) => {
+  jest.spyOn(requestClient, 'get').mockImplementation(url => {
     count++
     if (url.includes('job')) {
       return Promise.resolve({ result: mockJob, etag: '', status: 200 })
@@ -293,7 +293,7 @@ const mockSimplePoll = (runningCount = 2) => {
 
 const mockRunningPoll = () => {
   let count = 0
-  jest.spyOn(requestClient, 'get').mockImplementation((url) => {
+  jest.spyOn(requestClient, 'get').mockImplementation(url => {
     count++
     if (url.includes('job')) {
       return Promise.resolve({ result: mockJob, etag: '', status: 200 })
@@ -308,7 +308,7 @@ const mockRunningPoll = () => {
 
 const mockLongPoll = () => {
   let count = 0
-  jest.spyOn(requestClient, 'get').mockImplementation((url) => {
+  jest.spyOn(requestClient, 'get').mockImplementation(url => {
     count++
     if (url.includes('job')) {
       return Promise.resolve({ result: mockJob, etag: '', status: 200 })
@@ -323,7 +323,7 @@ const mockLongPoll = () => {
 
 const mockPollWithSingleError = () => {
   let count = 0
-  jest.spyOn(requestClient, 'get').mockImplementation((url) => {
+  jest.spyOn(requestClient, 'get').mockImplementation(url => {
     count++
     if (url.includes('job')) {
       return Promise.resolve({ result: mockJob, etag: '', status: 200 })
@@ -340,7 +340,7 @@ const mockPollWithSingleError = () => {
 }
 
 const mockErroredPoll = () => {
-  jest.spyOn(requestClient, 'get').mockImplementation((url) => {
+  jest.spyOn(requestClient, 'get').mockImplementation(url => {
     if (url.includes('job')) {
       return Promise.resolve({ result: mockJob, etag: '', status: 200 })
     }

src/api/viya/spec/saveLog.spec.ts

@@ -7,7 +7,7 @@ import { mockJob } from './mockResponses'
 import { WriteStream } from '../../../types'
 
 const requestClient = new (<jest.Mock<RequestClient>>RequestClient)()
-const stream = {} as unknown as WriteStream
+const stream = ({} as unknown) as WriteStream
 
 describe('saveLog', () => {
   beforeEach(() => {
@@ -17,7 +17,7 @@ describe('saveLog', () => {
 
   it('should throw an error when a valid access token is not provided', async () => {
     const error = await saveLog(mockJob, requestClient, 0, 100, stream).catch(
-      (e) => e
+      e => e
     )
 
     expect(error.message).toContain(
@@ -27,13 +27,13 @@ describe('saveLog', () => {
 
   it('should throw an error when the log URL is not available', async () => {
     const error = await saveLog(
-      { ...mockJob, links: mockJob.links.filter((l) => l.rel !== 'log') },
+      { ...mockJob, links: mockJob.links.filter(l => l.rel !== 'log') },
       requestClient,
       0,
       100,
       stream,
       't0k3n'
-    ).catch((e) => e)
+    ).catch(e => e)
 
     expect(error.message).toContain(
       `Log URL for job ${mockJob.id} was not found.`

src/api/viya/spec/uploadTables.spec.ts

@@ -29,9 +29,7 @@ describe('uploadTables', () => {
       .spyOn(convertToCsvModule, 'convertToCSV')
       .mockImplementation(() => 'ERROR: LARGE STRING LENGTH')
 
-    const error = await uploadTables(requestClient, data, 't0k3n').catch(
-      (e) => e
-    )
+    const error = await uploadTables(requestClient, data, 't0k3n').catch(e => e)
 
     expect(requestClient.uploadFile).not.toHaveBeenCalled()
     expect(error.message).toEqual(
@@ -45,9 +43,7 @@ describe('uploadTables', () => {
       .spyOn(requestClient, 'uploadFile')
       .mockImplementation(() => Promise.reject('Upload Error'))
 
-    const error = await uploadTables(requestClient, data, 't0k3n').catch(
-      (e) => e
-    )
+    const error = await uploadTables(requestClient, data, 't0k3n').catch(e => e)
 
     expect(error).toContain('Error while uploading file.')
   })

src/api/viya/spec/writeStream.spec.ts

@@ -28,7 +28,7 @@ describe('writeStream', () => {
     jest
       .spyOn(stream, 'write')
       .mockImplementation((_, callback) => callback(new Error('Test Error')))
-    const error = await writeStream(stream, content).catch((e) => e)
+    const error = await writeStream(stream, content).catch(e => e)
 
     expect(error.message).toEqual('Test Error')
   })

src/api/viya/uploadTables.ts

@@ -27,7 +27,7 @@ export async function uploadTables(
 
     const uploadResponse = await requestClient
       .uploadFile(`/files/files#rawUpload`, csv, accessToken)
-      .catch((err) => {
+      .catch(err => {
         throw prefixMessage(err, 'Error while uploading file. ')
       })
 

src/api/viya/writeStream.ts

@@ -4,7 +4,7 @@ export const writeStream = async (
   stream: WriteStream,
   content: string
 ): Promise<void> =>
-  stream.write(content + '\n', (e) => {
+  stream.write(content + '\n', e => {
     if (e) return Promise.reject(e)
 
     return Promise.resolve()