From 5a92d96ba29a20033376fb413bd511117f4684b5 Mon Sep 17 00:00:00 2001 From: sabhas Date: Fri, 4 Mar 2022 14:47:35 +0500 Subject: [PATCH 1/2] fix: Viya 4 provides incorrect memberCount --- src/SASViyaApiClient.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/SASViyaApiClient.ts b/src/SASViyaApiClient.ts index 53557e5..9b679a5 100644 --- a/src/SASViyaApiClient.ts +++ b/src/SASViyaApiClient.ts @@ -836,7 +836,9 @@ export class SASViyaApiClient { const { result: members } = await this.requestClient .get<{ items: any[] }>( - `/folders/folders/${folder.id}/members?limit=${folder.memberCount}`, + `/folders/folders/${folder.id}/members?limit=${ + folder.memberCount < 500 ? 500 : folder.memberCount + }`, // this is temporary fix for https://github.com/sasjs/adapter/issues/669 accessToken ) .catch((err) => { From 6adf8a2e78d6089bb780a0f19cee3f5c662256eb Mon Sep 17 00:00:00 2001 From: sabhas Date: Fri, 4 Mar 2022 15:08:50 +0500 Subject: [PATCH 2/2] chore: update comment --- src/SASViyaApiClient.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/SASViyaApiClient.ts b/src/SASViyaApiClient.ts index 9b679a5..b336b47 100644 --- a/src/SASViyaApiClient.ts +++ b/src/SASViyaApiClient.ts @@ -838,7 +838,7 @@ export class SASViyaApiClient { .get<{ items: any[] }>( `/folders/folders/${folder.id}/members?limit=${ folder.memberCount < 500 ? 500 : folder.memberCount - }`, // this is temporary fix for https://github.com/sasjs/adapter/issues/669 + }`, // this is a fix for https://github.com/sasjs/adapter/issues/669 accessToken ) .catch((err) => {