From 182e66216f3c8e482d4e0efa50d63573a610c508 Mon Sep 17 00:00:00 2001 From: Krishna Acondy Date: Wed, 25 Nov 2020 20:23:59 +0000 Subject: [PATCH 1/2] fix(*): export type declarations for node version of adapter --- .gitignore | 1 + package.json | 2 +- webpack.config.js | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index dd87e2d..67aedc2 100644 --- a/.gitignore +++ b/.gitignore @@ -1,2 +1,3 @@ node_modules build +node \ No newline at end of file diff --git a/package.json b/package.json index b12d40b..c3ad635 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "@sasjs/adapter", "description": "JavaScript adapter for SAS", "scripts": { - "build": "rimraf build && webpack", + "build": "rimraf build && rimraf node && mkdir node && cp -r src/* node && webpack && rimraf build/src", "package:lib": "npm run build && cp ./package.json build && cd build && npm version \"5.0.0\" && npm pack", "publish:lib": "npm run build && cd build && npm publish", "lint:fix": "npx prettier --write 'src/**/*.{ts,tsx,js,jsx,html,css,sass,less,json,yml,md,graphql}'", diff --git a/webpack.config.js b/webpack.config.js index 9e1434e..9801b10 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -47,6 +47,7 @@ const browserConfig = { const nodeConfig = { ...browserConfig, target: 'node', + entry: './node/index.ts', output: { ...browserConfig.output, path: path.resolve(__dirname, 'build', 'node') From 59e5bec7319f753848fd8434b50b6b01053fe16e Mon Sep 17 00:00:00 2001 From: Krishna Acondy Date: Wed, 25 Nov 2020 20:29:43 +0000 Subject: [PATCH 2/2] chore(*): fix PR template --- PULL_REQUEST_TEMPLATE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index ff37070..3f295a6 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -14,5 +14,5 @@ What code changes have been made to achieve the intent. - [ ] Code is formatted correctly (`npm run lint:fix`). - [ ] All unit tests are passing (`npm test`). -- [ ] All `sasjs-tests` unit tests are passing (`npm test`). +- [ ] All `sasjs-cli` unit tests are passing (`npm test`). - [ ] All `sasjs-tests` are passing (instructions available [here](https://github.com/sasjs/adapter/blob/master/sasjs-tests/README.md)).