From bbe9633dc8113ef5bc56a8781b141c7bdd91ee84 Mon Sep 17 00:00:00 2001 From: Yury Shkoda Date: Tue, 9 Mar 2021 15:52:00 +0300 Subject: [PATCH 1/3] fix(error-handling): console logged error --- src/SASViyaApiClient.ts | 5 ++++- src/request/RequestClient.ts | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/SASViyaApiClient.ts b/src/SASViyaApiClient.ts index 1b5e497..b52f7a5 100644 --- a/src/SASViyaApiClient.ts +++ b/src/SASViyaApiClient.ts @@ -1110,7 +1110,10 @@ export class SASViyaApiClient { 'text/plain' ) .catch((err) => { - throw prefixMessage(err, 'Error while getting job state. ') + throw prefixMessage( + err, + 'Error while getting job state after interval. ' + ) }) postedJobState = jobState.trim() diff --git a/src/request/RequestClient.ts b/src/request/RequestClient.ts index fd1cd28..d11a76d 100644 --- a/src/request/RequestClient.ts +++ b/src/request/RequestClient.ts @@ -106,6 +106,7 @@ export class RequestClient implements HttpClient { } ) ).catch((err) => { + console.log(`[err]`, err) throw prefixMessage(err, 'Error while handling error. ') }) }) From 15e1acaf4fb9fa785e65a8ed114a902ad7548b3a Mon Sep 17 00:00:00 2001 From: Yury Shkoda Date: Tue, 9 Mar 2021 17:11:29 +0300 Subject: [PATCH 2/3] fix(error-handling): catching unhandled promise rejection --- src/request/RequestClient.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/request/RequestClient.ts b/src/request/RequestClient.ts index d11a76d..4c61eef 100644 --- a/src/request/RequestClient.ts +++ b/src/request/RequestClient.ts @@ -93,6 +93,7 @@ export class RequestClient implements HttpClient { .get(url, requestConfig) .then((response) => { throwIfError(response) + return this.parseResponse(response) }) .catch(async (e) => { @@ -106,7 +107,6 @@ export class RequestClient implements HttpClient { } ) ).catch((err) => { - console.log(`[err]`, err) throw prefixMessage(err, 'Error while handling error. ') }) }) @@ -388,6 +388,8 @@ export class RequestClient implements HttpClient { throw new NotFoundError(response.config.url!) } + console.log(`[e]`, e) + throw e } @@ -456,7 +458,10 @@ const throwIfError = (response: AxiosResponse) => { throw new AuthorizeError(response.data.message, authorizeRequestUrl) } + console.log(`[response]`, response) + const error = parseError(response.data as string) + if (error) { throw error } From 599c13039508cc3b7eb123813e57a3364b047752 Mon Sep 17 00:00:00 2001 From: Yury Shkoda Date: Tue, 9 Mar 2021 18:06:27 +0300 Subject: [PATCH 3/3] fix(error-handling): fixed console.log --- src/request/RequestClient.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/request/RequestClient.ts b/src/request/RequestClient.ts index 4c61eef..16a0e97 100644 --- a/src/request/RequestClient.ts +++ b/src/request/RequestClient.ts @@ -458,8 +458,6 @@ const throwIfError = (response: AxiosResponse) => { throw new AuthorizeError(response.data.message, authorizeRequestUrl) } - console.log(`[response]`, response) - const error = parseError(response.data as string) if (error) {