chore(refactor): only fetch job if streaming logs, fix tests, add JSDoc comments

src/api/viya/saveLog.ts

@@ -4,20 +4,25 @@ import { fetchLog } from '../../utils'
 import { WriteStream } from 'fs'
 import { writeStream } from './writeStream'
 
+/**
+ * Appends logs to a supplied write stream.
+ * This is useful for getting quick feedback on longer running jobs.
+ * @param job - the job to fetch logs for
+ * @param requestClient - the pre-configured HTTP request client
+ * @param startLine - the line at which to start fetching the log
+ * @param endLine - the line at which to stop fetching the log
+ * @param logFileStream - the write stream to which the log is appended
+ * @accessToken - an optional access token for authentication/authorization
+ * The access token is not required when fetching logs from the browser.
+ */
 export async function saveLog(
   job: Job,
   requestClient: RequestClient,
-  shouldSaveLog: boolean,
   startLine: number,
   endLine: number,
   logFileStream?: WriteStream,
   accessToken?: string
 ) {
-  console.log('startLine: ', startLine, ' endLine: ', endLine)
-  if (!shouldSaveLog) {
-    return
-  }
-
   if (!accessToken) {
     throw new Error(
       `Logs for job ${job.id} cannot be fetched without a valid access token.`