sasjs/core
1
0
Fork 0
mirror of https://github.com/sasjs/core.git synced 2026-01-08 18:00:06 +00:00
Code Issues Projects Releases Wiki Activity

fix: removing endsas for 9.4m6+ WIN enviornments in mp_abort

Browse Source
This commit is contained in:
Allan Bowe
2022-06-28 13:46:07 +00:00
parent 1f369f9848
commit cf0d1c0473
2 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
all.sas
View File

@@ -2191,8 +2191,10 @@ Usage:
The method used varies according to the context. Important points: The method used varies according to the context. Important points:
@li should not use endsas or abort cancel in 9.4m3 environments as this can @li should not use endsas or abort cancel in 9.4m3 WIN environments as this
cause hung multibridge sessions and result in a frozen STP server can cause hung multibridge sessions and result in a frozen STP server
@li The use of endsas in 9.4m6+ windows environments for POST requests to the
STP server can result in an empty response body
@li should not use endsas in viya 3.5 as this destroys the session and cannot @li should not use endsas in viya 3.5 as this destroys the session and cannot
fetch results (although both mv_getjoblog.sas and the @sasjs/adapter will fetch results (although both mv_getjoblog.sas and the @sasjs/adapter will
recognise this and fetch the log of the parent session instead) recognise this and fetch the log of the parent session instead)
@@ -2204,8 +2206,8 @@ Usage:
a macro. For that, we recommend you use mp_include.sas to perform the a macro. For that, we recommend you use mp_include.sas to perform the
include, and then call \%mp_abort(mode=INCLUDE) from the source program (ie, include, and then call \%mp_abort(mode=INCLUDE) from the source program (ie,
OUTSIDE of the top-parent macro). OUTSIDE of the top-parent macro).
The soft abort has also been found to be ineffective in 9.4m6 windows The soft abort has become ineffective in 9.4m6 WINDOWS environments. We are
environments and above, so in these cases, endsas is used. currently investigating approaches to deal with this.
@param mac= (mp_abort.sas) To contain the name of the calling macro. Do not @param mac= (mp_abort.sas) To contain the name of the calling macro. Do not
@@ -2430,6 +2432,7 @@ and %superq(SYSPROCESSNAME) ne %str(Compute Server)
call symputx("syscc",0,"g"); call symputx("syscc",0,"g");
run; run;
%if &sysscp=WIN %if &sysscp=WIN
and 1=0 /* deprecating this logic until we figure out a consistent abort */
and "%substr(%str(&sysvlong ),1,8)"="9.04.01M" and "%substr(%str(&sysvlong ),1,8)"="9.04.01M"
and "%substr(%str(&sysvlong ),9,1)">"5" %then %do; and "%substr(%str(&sysvlong ),9,1)">"5" %then %do;
/* skip approach (below) does not work in windows m6+ envs */ /* skip approach (below) does not work in windows m6+ envs */

11
base/mp_abort.sas
View File

@@ -8,8 +8,10 @@
The method used varies according to the context. Important points: The method used varies according to the context. Important points:
@li should not use endsas or abort cancel in 9.4m3 environments as this can @li should not use endsas or abort cancel in 9.4m3 WIN environments as this
cause hung multibridge sessions and result in a frozen STP server can cause hung multibridge sessions and result in a frozen STP server
@li The use of endsas in 9.4m6+ windows environments for POST requests to the
STP server can result in an empty response body
@li should not use endsas in viya 3.5 as this destroys the session and cannot @li should not use endsas in viya 3.5 as this destroys the session and cannot
fetch results (although both mv_getjoblog.sas and the @sasjs/adapter will fetch results (although both mv_getjoblog.sas and the @sasjs/adapter will
recognise this and fetch the log of the parent session instead) recognise this and fetch the log of the parent session instead)
@@ -21,8 +23,8 @@
a macro. For that, we recommend you use mp_include.sas to perform the a macro. For that, we recommend you use mp_include.sas to perform the
include, and then call \%mp_abort(mode=INCLUDE) from the source program (ie, include, and then call \%mp_abort(mode=INCLUDE) from the source program (ie,
OUTSIDE of the top-parent macro). OUTSIDE of the top-parent macro).
The soft abort has also been found to be ineffective in 9.4m6 windows The soft abort has become ineffective in 9.4m6 WINDOWS environments. We are
environments and above, so in these cases, endsas is used. currently investigating approaches to deal with this.
@param mac= (mp_abort.sas) To contain the name of the calling macro. Do not @param mac= (mp_abort.sas) To contain the name of the calling macro. Do not
@@ -247,6 +249,7 @@ and %superq(SYSPROCESSNAME) ne %str(Compute Server)
call symputx("syscc",0,"g"); call symputx("syscc",0,"g");
run; run;
%if &sysscp=WIN %if &sysscp=WIN
and 1=0 /* deprecating this logic until we figure out a consistent abort */
and "%substr(%str(&sysvlong ),1,8)"="9.04.01M" and "%substr(%str(&sysvlong ),1,8)"="9.04.01M"
and "%substr(%str(&sysvlong ),9,1)">"5" %then %do; and "%substr(%str(&sysvlong ),9,1)">"5" %then %do;
/* skip approach (below) does not work in windows m6+ envs */ /* skip approach (below) does not work in windows m6+ envs */