From 8910840ccc5c4156d9d1a8322dc2e3ed3d42db2b Mon Sep 17 00:00:00 2001 From: munja Date: Wed, 28 Dec 2022 20:17:08 +0000 Subject: [PATCH] fix: increasing desc length to 256 in ms_getgroups --- .sasjslint | 1 + all.sas | 19 ++++++++++--------- meta/mm_createwebservice.sas | 2 +- server/ms_createwebservice.sas | 2 +- server/ms_getgroups.sas | 8 ++++---- 5 files changed, 17 insertions(+), 15 deletions(-) diff --git a/.sasjslint b/.sasjslint index bee0905..bc82030 100644 --- a/.sasjslint +++ b/.sasjslint @@ -4,6 +4,7 @@ "hasDoxygenHeader": true, "hasMacroNameInMend": true, "hasMacroParentheses": true, + "noGremlins": true, "noNestedMacros": false, "noSpacesInFileNames": true, "maxLineLength": 300, diff --git a/all.sas b/all.sas index d8a6721..20bb8e2 100644 --- a/all.sas +++ b/all.sas @@ -247,7 +247,8 @@ options noquotelenmax; 0 %end; -%mend mf_existfileref;/** +%mend mf_existfileref; +/** @file @brief Checks if a function exists @details Returns 1 if the function exists, else 0. Note that this function @@ -16439,7 +16440,7 @@ data _null_; put ' put " ""&wt"" : {"; '; put ' put ''"nlobs":'' nlobs; '; put ' put '',"nvars":'' nvars; '; - put ' %mp_jsonout(OBJ,&wt,jref=_sjsref,dslabel=first10rows,showmeta=Y,maxobs=10 '; + put ' %mp_jsonout(OBJ,&wt,jref=_sjsref,dslabel=first10rows,showmeta=Y '; put ' ,maxobs=&workobs '; put ' ) '; put ' data _null_; file _sjsref mod encoding=''utf-8''; '; @@ -20121,7 +20122,7 @@ run; put " ""&wt"" : {"; put '"nlobs":' nlobs; put ',"nvars":' nvars; - %mp_jsonout(OBJ,&wt,jref=_sjsref,dslabel=first10rows,showmeta=Y,maxobs=10 + %mp_jsonout(OBJ,&wt,jref=_sjsref,dslabel=first10rows,showmeta=Y ,maxobs=&workobs ) data _null_; file _sjsref mod encoding='utf-8'; @@ -21525,7 +21526,7 @@ data _null_; put ' put " ""&wt"" : {"; '; put ' put ''"nlobs":'' nlobs; '; put ' put '',"nvars":'' nvars; '; - put ' %mp_jsonout(OBJ,&wt,jref=&fref,dslabel=first10rows,showmeta=Y,maxobs=10 '; + put ' %mp_jsonout(OBJ,&wt,jref=&fref,dslabel=first10rows,showmeta=Y '; put ' ,maxobs=&workobs '; put ' ) '; put ' data _null_; file &fref mod encoding=''utf-8'' termstr=lf; '; @@ -21792,7 +21793,7 @@ filename &headref clear; @param [in] uid= (0) Provide the userid on which to filter @param [out] outds= (work.ms_getgroups) This output dataset will contain the list of groups. Format: -|NAME:$32.|DESCRIPTION:$64.|GROUPID:best.| +|NAME:$32.|DESCRIPTION:$256.|GROUPID:best.| |---|---|---| |`SomeGroup `|`A group `|`1`| |`Another Group`|`this is a different group`|`2`| @@ -21828,7 +21829,7 @@ filename &headref clear; %if %sysget(MODE)=desktop %then %do; /* groups api does not exist in desktop mode */ data &outds; - length NAME $32 DESCRIPTION $64. GROUPID 8; + length NAME $32 DESCRIPTION $256. GROUPID 8; name="&sysuserid"; description="&sysuserid (group - desktop mode)"; groupid=1; @@ -21884,7 +21885,7 @@ libname &libref JSON fileref=&fref1; %if "&user"="0" and "&uid"="0" %then %do; data &outds; - length NAME $32 DESCRIPTION $64. GROUPID 8; + length NAME $32 DESCRIPTION $256. GROUPID 8; if _n_=1 then call missing(of _all_); set &libref..root; drop ordinal_root; @@ -21892,7 +21893,7 @@ libname &libref JSON fileref=&fref1; %end; %else %do; data &outds; - length NAME $32 DESCRIPTION $64. GROUPID 8; + length NAME $32 DESCRIPTION $256. GROUPID 8; if _n_=1 then call missing(of _all_); set &libref..groups; drop ordinal_:; @@ -22558,7 +22559,7 @@ run; put " ""&wt"" : {"; put '"nlobs":' nlobs; put ',"nvars":' nvars; - %mp_jsonout(OBJ,&wt,jref=&fref,dslabel=first10rows,showmeta=Y,maxobs=10 + %mp_jsonout(OBJ,&wt,jref=&fref,dslabel=first10rows,showmeta=Y ,maxobs=&workobs ) data _null_; file &fref mod encoding='utf-8' termstr=lf; diff --git a/meta/mm_createwebservice.sas b/meta/mm_createwebservice.sas index c1439b5..cea37b1 100644 --- a/meta/mm_createwebservice.sas +++ b/meta/mm_createwebservice.sas @@ -546,7 +546,7 @@ data _null_; put ' put " ""&wt"" : {"; '; put ' put ''"nlobs":'' nlobs; '; put ' put '',"nvars":'' nvars; '; - put ' %mp_jsonout(OBJ,&wt,jref=_sjsref,dslabel=first10rows,showmeta=Y,maxobs=10 '; + put ' %mp_jsonout(OBJ,&wt,jref=_sjsref,dslabel=first10rows,showmeta=Y '; put ' ,maxobs=&workobs '; put ' ) '; put ' data _null_; file _sjsref mod encoding=''utf-8''; '; diff --git a/server/ms_createwebservice.sas b/server/ms_createwebservice.sas index 82dc54c..e8ab517 100644 --- a/server/ms_createwebservice.sas +++ b/server/ms_createwebservice.sas @@ -539,7 +539,7 @@ data _null_; put ' put " ""&wt"" : {"; '; put ' put ''"nlobs":'' nlobs; '; put ' put '',"nvars":'' nvars; '; - put ' %mp_jsonout(OBJ,&wt,jref=&fref,dslabel=first10rows,showmeta=Y,maxobs=10 '; + put ' %mp_jsonout(OBJ,&wt,jref=&fref,dslabel=first10rows,showmeta=Y '; put ' ,maxobs=&workobs '; put ' ) '; put ' data _null_; file &fref mod encoding=''utf-8'' termstr=lf; '; diff --git a/server/ms_getgroups.sas b/server/ms_getgroups.sas index 43d9717..b21794b 100644 --- a/server/ms_getgroups.sas +++ b/server/ms_getgroups.sas @@ -22,7 +22,7 @@ @param [in] uid= (0) Provide the userid on which to filter @param [out] outds= (work.ms_getgroups) This output dataset will contain the list of groups. Format: -|NAME:$32.|DESCRIPTION:$64.|GROUPID:best.| +|NAME:$32.|DESCRIPTION:$256.|GROUPID:best.| |---|---|---| |`SomeGroup `|`A group `|`1`| |`Another Group`|`this is a different group`|`2`| @@ -58,7 +58,7 @@ %if %sysget(MODE)=desktop %then %do; /* groups api does not exist in desktop mode */ data &outds; - length NAME $32 DESCRIPTION $64. GROUPID 8; + length NAME $32 DESCRIPTION $256. GROUPID 8; name="&sysuserid"; description="&sysuserid (group - desktop mode)"; groupid=1; @@ -114,7 +114,7 @@ libname &libref JSON fileref=&fref1; %if "&user"="0" and "&uid"="0" %then %do; data &outds; - length NAME $32 DESCRIPTION $64. GROUPID 8; + length NAME $32 DESCRIPTION $256. GROUPID 8; if _n_=1 then call missing(of _all_); set &libref..root; drop ordinal_root; @@ -122,7 +122,7 @@ libname &libref JSON fileref=&fref1; %end; %else %do; data &outds; - length NAME $32 DESCRIPTION $64. GROUPID 8; + length NAME $32 DESCRIPTION $256. GROUPID 8; if _n_=1 then call missing(of _all_); set &libref..groups; drop ordinal_:;