fix: for PGSQL DDL generation, ignore tables with over 1600 columns (as they are not supported in Postgres)

all.sas

@@ -4398,6 +4398,7 @@ run;
 
   <h4> SAS Macros </h4>
   @li mf_existfileref.sas
+  @li mf_getvarcount.sas
   @li mp_getconstraints.sas
 
   @param lib libref of the library to create DDL for.  Should be assigned.
@@ -4419,8 +4420,8 @@ run;
 )/*/STORE SOURCE*/;
 
 /* check fileref is assigned */
-%if %mf_existfileref(&outref)=0 %then %do;
+%if %mf_existfileref(&fref)=0 %then %do;
-  filename &outref temp ;
+  filename &fref temp ;
 %end;
 
 %if %length(&libref)=0 %then %let libref=WORK;
@@ -4685,6 +4686,17 @@ run;
     put "CREATE SCHEMA &schema;";
   %do x=1 %to %sysfunc(countw(&dsnlist));
     %let curds=%scan(&dsnlist,&x);
+    %local curdsvarcount;
+    %let curdsvarcount=%mf_getvarcount(&libref..&curds);
+    %if &curdsvarcount>1600 %then %do;
+      data _null_;
+        file &fref mod;
+        put "/* &libref..&curds contains &curdsvarcount vars */";
+        put "/* Postgres cannot create tables with over 1600 vars */";
+        put "/* No DDL will be generated for this table";
+      run;
+    %end;
+    %else %do;
       data _null_;
         file &fref mod;
         put "/* Postgres Flavour DDL for &schema..&curds */";
@@ -4738,18 +4750,16 @@ run;
         );
         file &fref mod;
         by idxusage indxname;
-/*       ds=cats(libname,'.',memname); */
         if first.indxname then do;
           put 'CREATE UNIQUE INDEX "' indxname +(-1) '" ' "ON &schema..&curds(";
           put '  "' name +(-1) '"' ;
         end;
         else put '  ,"' name +(-1) '"';
-      *else put '    ,' name ;
         if last.indxname then do;
           put ');';
         end;
       run;
-
+    %end;
   %end;
 %end;
 %if %upcase(&showlog)=YES %then %do;
@@ -5158,8 +5168,7 @@ create table &outds (rename=(
   @li mf_getvartype.sas
 
   @param [in] libds dataset to hash
-  @param [in] salt= Provide a salt (could be, for instance, the name of the
+  @param [in] salt= Provide a salt (could be, for instance, the dataset name)
-    dataset). Max 32 chars.
   @param [out] outds= (work.mf_hashdataset) The output dataset to create. This
   will contain one column (hashkey) with one observation (a hex32.
   representation of the input hash)
@@ -5194,7 +5203,7 @@ create table &outds (rename=(
     %let varlist=%mf_getvarlist(&libds);
     data &outds(rename=(&keyvar=hashkey) keep=&keyvar);
       length &prevkeyvar &keyvar $32;
-      retain &prevkeyvar "&salt";
+      retain &prevkeyvar "%sysfunc(md5(%str(&salt)),$hex32.)";
       set &libds end=&lastvar;
       /* hash should include previous row */
       &keyvar=put(md5(&prevkeyvar

base/mp_getddl.sas

@@ -17,6 +17,7 @@
 
   <h4> SAS Macros </h4>
   @li mf_existfileref.sas
+  @li mf_getvarcount.sas
   @li mp_getconstraints.sas
 
   @param lib libref of the library to create DDL for.  Should be assigned.
@@ -38,8 +39,8 @@
 )/*/STORE SOURCE*/;
 
 /* check fileref is assigned */
-%if %mf_existfileref(&outref)=0 %then %do;
+%if %mf_existfileref(&fref)=0 %then %do;
-  filename &outref temp ;
+  filename &fref temp ;
 %end;
 
 %if %length(&libref)=0 %then %let libref=WORK;
@@ -304,6 +305,17 @@ run;
     put "CREATE SCHEMA &schema;";
   %do x=1 %to %sysfunc(countw(&dsnlist));
     %let curds=%scan(&dsnlist,&x);
+    %local curdsvarcount;
+    %let curdsvarcount=%mf_getvarcount(&libref..&curds);
+    %if &curdsvarcount>1600 %then %do;
+      data _null_;
+        file &fref mod;
+        put "/* &libref..&curds contains &curdsvarcount vars */";
+        put "/* Postgres cannot create tables with over 1600 vars */";
+        put "/* No DDL will be generated for this table";
+      run;
+    %end;
+    %else %do;
       data _null_;
         file &fref mod;
         put "/* Postgres Flavour DDL for &schema..&curds */";
@@ -357,18 +369,16 @@ run;
         );
         file &fref mod;
         by idxusage indxname;
-/*       ds=cats(libname,'.',memname); */
         if first.indxname then do;
           put 'CREATE UNIQUE INDEX "' indxname +(-1) '" ' "ON &schema..&curds(";
           put '  "' name +(-1) '"' ;
         end;
         else put '  ,"' name +(-1) '"';
-      *else put '    ,' name ;
         if last.indxname then do;
           put ');';
         end;
       run;
-
+    %end;
   %end;
 %end;
 %if %upcase(&showlog)=YES %then %do;

base/mp_hashdataset.sas

@@ -20,8 +20,7 @@
   @li mf_getvartype.sas
 
   @param [in] libds dataset to hash
-  @param [in] salt= Provide a salt (could be, for instance, the name of the
+  @param [in] salt= Provide a salt (could be, for instance, the dataset name)
-    dataset). Max 32 chars.
   @param [out] outds= (work.mf_hashdataset) The output dataset to create. This
   will contain one column (hashkey) with one observation (a hex32.
   representation of the input hash)
@@ -56,7 +55,7 @@
     %let varlist=%mf_getvarlist(&libds);
     data &outds(rename=(&keyvar=hashkey) keep=&keyvar);
       length &prevkeyvar &keyvar $32;
-      retain &prevkeyvar "&salt";
+      retain &prevkeyvar "%sysfunc(md5(%str(&salt)),$hex32.)";
       set &libds end=&lastvar;
       /* hash should include previous row */
       &keyvar=put(md5(&prevkeyvar

tests/base/mp_getddl.test.sas

@@ -0,0 +1,23 @@
+/**
+  @file
+  @brief Testing mp_getddl.sas macro
+
+  <h4> SAS Macros </h4>
+  @li mp_getddl.sas
+  @li mp_assert.sas
+
+**/
+
+data test(index=(pk=(x y)/unique /nomiss));
+  x=1;
+  y='blah';
+  label x='blah';
+run;
+proc sql; describe table &syslast;
+%mp_getddl(work,test,flavour=tsql,showlog=YES)
+
+%mp_assert(
+  iftrue=(&syscc=0),
+  desc=mp_getddl runs without errors,
+  outds=work.test_results
+)