From 020a1e08d0f1180092a9021a9013f8c9cc0870c5 Mon Sep 17 00:00:00 2001 From: Saad Jutt Date: Fri, 21 May 2021 20:16:24 +0500 Subject: [PATCH] chore: prevent space b/w macroName and starting parentheses is not applicable --- src/rules/file/hasMacroParentheses.spec.ts | 14 -------------- src/rules/file/hasMacroParentheses.ts | 12 ------------ 2 files changed, 26 deletions(-) diff --git a/src/rules/file/hasMacroParentheses.spec.ts b/src/rules/file/hasMacroParentheses.spec.ts index 3ace5ce..3bd7b2c 100644 --- a/src/rules/file/hasMacroParentheses.spec.ts +++ b/src/rules/file/hasMacroParentheses.spec.ts @@ -139,18 +139,4 @@ describe('hasMacroParentheses', () => { ]) }) }) - - // it('should return an array with a single diagnostic when a macro definition contains a space', () => { - // const content = `%macro test ()` - - // expect(hasMacroParentheses.test(content)).toEqual([ - // { - // message: 'Macro definition contains space(s)', - // lineNumber: 1, - // startColumnNumber: 8, - // endColumnNumber: 14, - // severity: Severity.Warning - // } - // ]) - // }) }) diff --git a/src/rules/file/hasMacroParentheses.ts b/src/rules/file/hasMacroParentheses.ts index 13d15e5..435d98d 100644 --- a/src/rules/file/hasMacroParentheses.ts +++ b/src/rules/file/hasMacroParentheses.ts @@ -46,18 +46,6 @@ const test = (value: string, config?: LintConfig) => { 1, severity: Severity.Warning }) - // } else if (macro.name !== macro.name.trim()) { - // diagnostics.push({ - // message: 'Macro definition contains space(s)', - // lineNumber: macro.startLineNumber!, - // startColumnNumber: getColumnNumber(macro.declarationLine, macro.name), - // endColumnNumber: - // getColumnNumber(macro.declarationLine, macro.name) + - // macro.name.length - - // 1 + - // `()`.length, - // severity: Severity.Warning - // }) } })