From 36b3a7f319a1dd641871533bf04bbd5d2081990a Mon Sep 17 00:00:00 2001
From: Saad Jutt <ihsan.distranger@gmail.com>
Date: Thu, 15 Apr 2021 20:45:27 +0500
Subject: [PATCH] chore(tests): changed numeric literals -> consts

---
 src/lint/lintFile.spec.ts       |  4 +++-
 src/lint/lintFolder.spec.ts     |  7 +++++--
 src/lint/lintProject.spec.ts    |  7 +++++--
 src/utils/getLintConfig.spec.ts | 10 +++++++---
 4 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/src/lint/lintFile.spec.ts b/src/lint/lintFile.spec.ts
index 96a2af1..1658e43 100644
--- a/src/lint/lintFile.spec.ts
+++ b/src/lint/lintFile.spec.ts
@@ -2,13 +2,15 @@ import { lintFile } from './lintFile'
 import { Severity } from '../types/Severity'
 import path from 'path'
 
+const expectedDiagnosticsCount = 9
+
 describe('lintFile', () => {
   it('should identify lint issues in a given file', async () => {
     const results = await lintFile(
       path.join(__dirname, '..', 'Example File.sas')
     )
 
-    expect(results.length).toEqual(9)
+    expect(results.length).toEqual(expectedDiagnosticsCount)
     expect(results).toContainEqual({
       message: 'Line contains trailing spaces',
       lineNumber: 1,
diff --git a/src/lint/lintFolder.spec.ts b/src/lint/lintFolder.spec.ts
index 6cde363..ae5dae4 100644
--- a/src/lint/lintFolder.spec.ts
+++ b/src/lint/lintFolder.spec.ts
@@ -2,15 +2,18 @@ import { lintFolder } from './lintFolder'
 import { Severity } from '../types/Severity'
 import path from 'path'
 
+const expectedFilesCount = 1
+const expectedDiagnosticsCount = 9
+
 describe('lintFolder', () => {
   it('should identify lint issues in a given folder', async () => {
     const results = await lintFolder(path.join(__dirname, '..'))
 
-    expect(results.size).toEqual(1)
+    expect(results.size).toEqual(expectedFilesCount)
     const diagnostics = results.get(
       path.join(__dirname, '..', 'Example File.sas')
     )!
-    expect(diagnostics.length).toEqual(9)
+    expect(diagnostics.length).toEqual(expectedDiagnosticsCount)
     expect(diagnostics).toContainEqual({
       message: 'Line contains trailing spaces',
       lineNumber: 1,
diff --git a/src/lint/lintProject.spec.ts b/src/lint/lintProject.spec.ts
index 223c88e..4544be5 100644
--- a/src/lint/lintProject.spec.ts
+++ b/src/lint/lintProject.spec.ts
@@ -4,6 +4,9 @@ import * as utils from '../utils'
 import path from 'path'
 jest.mock('../utils')
 
+const expectedFilesCount = 1
+const expectedDiagnosticsCount = 9
+
 describe('lintProject', () => {
   it('should identify lint issues in a given project', async () => {
     jest
@@ -11,11 +14,11 @@ describe('lintProject', () => {
       .mockImplementationOnce(() => Promise.resolve(path.join(__dirname, '..')))
     const results = await lintProject()
 
-    expect(results.size).toEqual(1)
+    expect(results.size).toEqual(expectedFilesCount)
     const diagnostics = results.get(
       path.join(__dirname, '..', 'Example File.sas')
     )!
-    expect(diagnostics.length).toEqual(9)
+    expect(diagnostics.length).toEqual(expectedDiagnosticsCount)
     expect(diagnostics).toContainEqual({
       message: 'Line contains trailing spaces',
       lineNumber: 1,
diff --git a/src/utils/getLintConfig.spec.ts b/src/utils/getLintConfig.spec.ts
index f59570d..5ada859 100644
--- a/src/utils/getLintConfig.spec.ts
+++ b/src/utils/getLintConfig.spec.ts
@@ -2,6 +2,10 @@ import * as fileModule from '@sasjs/utils/file'
 import { LintConfig } from '../types/LintConfig'
 import { getLintConfig } from './getLintConfig'
 
+const expectedFileLintRulesCount = 4
+const expectedLineLintRulesCount = 5
+const expectedPathLintRulesCount = 2
+
 describe('getLintConfig', () => {
   it('should get the lint config', async () => {
     const config = await getLintConfig()
@@ -17,8 +21,8 @@ describe('getLintConfig', () => {
     const config = await getLintConfig()
 
     expect(config).toBeInstanceOf(LintConfig)
-    expect(config.fileLintRules.length).toEqual(4)
-    expect(config.lineLintRules.length).toEqual(5)
-    expect(config.pathLintRules.length).toEqual(2)
+    expect(config.fileLintRules.length).toEqual(expectedFileLintRulesCount)
+    expect(config.lineLintRules.length).toEqual(expectedLineLintRulesCount)
+    expect(config.pathLintRules.length).toEqual(expectedPathLintRulesCount)
   })
 })