diff --git a/src/types/LintConfig.spec.ts b/src/types/LintConfig.spec.ts index a5d97d9..5586f22 100644 --- a/src/types/LintConfig.spec.ts +++ b/src/types/LintConfig.spec.ts @@ -31,7 +31,7 @@ describe('LintConfig', () => { ).toBeUndefined() }) - it('should create an instance with the maxLineLength flag off', () => { + it('should create an instance with the maxLineLength flag off by setting value to 0', () => { const config = new LintConfig({ maxLineLength: 0 }) expect(config).toBeTruthy() @@ -42,6 +42,17 @@ describe('LintConfig', () => { ).toBeUndefined() }) + it('should create an instance with the maxLineLength flag off by setting value to a negative number', () => { + const config = new LintConfig({ maxLineLength: -1 }) + + expect(config).toBeTruthy() + expect(config.lineLintRules.length).toBeGreaterThan(0) + expect(config.fileLintRules.length).toBeGreaterThan(0) + expect( + config.lineLintRules.find((rule) => rule.name === 'maxLineLength') + ).toBeUndefined() + }) + it('should create an instance with the hasDoxygenHeader flag off', () => { const config = new LintConfig({ hasDoxygenHeader: false }) diff --git a/src/types/LintConfig.ts b/src/types/LintConfig.ts index 7a4e028..7a490f3 100644 --- a/src/types/LintConfig.ts +++ b/src/types/LintConfig.ts @@ -68,12 +68,9 @@ export class LintConfig { this.lineLintRules.pop() } - if (json?.maxLineLength) { + if (json?.maxLineLength > 0) { this.lineLintRules.push(maxLineLength) - - if (!isNaN(json?.maxLineLength)) { - this.maxLineLength = json.maxLineLength - } + this.maxLineLength = json.maxLineLength if (!isNaN(json?.maxHeaderLineLength)) { this.maxHeaderLineLength = json.maxHeaderLineLength