1
0
mirror of https://github.com/sasjs/lint.git synced 2026-01-05 03:30:06 +00:00

feat: added hasRequiredMacroOptions

This commit is contained in:
mac.homelab
2025-01-28 09:55:11 -05:00
parent 3e4809c352
commit be173d2e2b
6 changed files with 225 additions and 2 deletions

View File

@@ -1,3 +1,4 @@
import { hasRequiredMacroOptions } from '../rules/file'
import { LineEndings } from './LineEndings'
import { LintConfig } from './LintConfig'
import { LintRuleType } from './LintRuleType'
@@ -168,6 +169,7 @@ describe('LintConfig', () => {
hasMacroNameInMend: true,
noNestedMacros: true,
hasMacroParentheses: true,
hasRequiredMacroOptions: true,
noGremlins: true,
lineEndings: 'lf'
})
@@ -187,7 +189,7 @@ describe('LintConfig', () => {
expect(config.lineLintRules[5].name).toEqual('noGremlins')
expect(config.lineLintRules[5].type).toEqual(LintRuleType.Line)
expect(config.fileLintRules.length).toEqual(6)
expect(config.fileLintRules.length).toEqual(7)
expect(config.fileLintRules[0].name).toEqual('lineEndings')
expect(config.fileLintRules[0].type).toEqual(LintRuleType.File)
expect(config.fileLintRules[1].name).toEqual('hasDoxygenHeader')
@@ -200,6 +202,8 @@ describe('LintConfig', () => {
expect(config.fileLintRules[4].type).toEqual(LintRuleType.File)
expect(config.fileLintRules[5].name).toEqual('strictMacroDefinition')
expect(config.fileLintRules[5].type).toEqual(LintRuleType.File)
expect(config.fileLintRules[6].name).toEqual('hasRequiredMacroOptions')
expect(config.fileLintRules[6].type).toEqual(LintRuleType.File)
expect(config.pathLintRules.length).toEqual(2)
expect(config.pathLintRules[0].name).toEqual('noSpacesInFileNames')
@@ -207,4 +211,25 @@ describe('LintConfig', () => {
expect(config.pathLintRules[1].name).toEqual('lowerCaseFileNames')
expect(config.pathLintRules[1].type).toEqual(LintRuleType.Path)
})
it('should throw an error with an invalid value for requiredMacroOptions', () => {
expect(
() =>
new LintConfig({
hasRequiredMacroOptions: true,
requiredMacroOptions: 'test'
})
).toThrowError(
`Property "requiredMacroOptions" can only be an array of strings.`
)
expect(
() =>
new LintConfig({
hasRequiredMacroOptions: true,
requiredMacroOptions: ['test', 2]
})
).toThrowError(
`Property "requiredMacroOptions" has invalid type of values. It can only contain strings.`
)
})
})

View File

@@ -4,7 +4,8 @@ import {
noNestedMacros,
hasMacroParentheses,
lineEndings,
strictMacroDefinition
strictMacroDefinition,
hasRequiredMacroOptions
} from '../rules/file'
import {
indentationMultiple,
@@ -40,6 +41,7 @@ export class LintConfig {
readonly lineEndings: LineEndings = LineEndings.LF
readonly defaultHeader: string = getDefaultHeader()
readonly severityLevel: { [key: string]: Severity } = {}
readonly requiredMacroOptions: string[] = []
constructor(json?: any) {
if (json?.ignoreList) {
@@ -132,6 +134,31 @@ export class LintConfig {
this.fileLintRules.push(strictMacroDefinition)
}
if (json?.hasRequiredMacroOptions) {
this.fileLintRules.push(hasRequiredMacroOptions)
if (json?.requiredMacroOptions) {
if (
Array.isArray(json.requiredMacroOptions) &&
json.requiredMacroOptions.length > 0
) {
json.requiredMacroOptions.forEach((item: any) => {
if (typeof item === 'string') {
this.requiredMacroOptions.push(item)
} else {
throw new Error(
`Property "requiredMacroOptions" has invalid type of values. It can only contain strings.`
)
}
})
} else {
throw new Error(
`Property "requiredMacroOptions" can only be an array of strings.`
)
}
}
}
if (json?.noGremlins !== false) {
this.lineLintRules.push(noGremlins)