sasjs/server
1
0
Fork 0
mirror of https://github.com/sasjs/server.git synced 2026-01-12 08:40:04 +00:00
Code Issues Projects Releases Wiki Activity

fix: remove clientId from principal types

Browse Source
This commit is contained in:
Sabir Hassan
2022-05-16 19:56:56 +05:00
parent 7be77cc38a
commit 0781ddd64e
4 changed files with 5 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
api/src/routes/api/spec/permission.spec.ts
View File

@@ -108,28 +108,6 @@ describe('permission', () => {
expect(res.body.group).toBeTruthy()
})
it('should respond with new permission when principalType is client', async () => {
const dbclient = await clientController.createClient({
clientId: '123456789',
clientSecret: '123456789'
})
const res = await request(app)
.post('/SASjsApi/permission')
.auth(adminAccessToken, { type: 'bearer' })
.send({
...permission,
principalType: 'client',
principalId: dbclient.clientId
})
.expect(200)
expect(res.body.permissionId).toBeTruthy()
expect(res.body.uri).toEqual(permission.uri)
expect(res.body.setting).toEqual(permission.setting)
expect(res.body.clientId).toEqual(dbclient.clientId)
})
it('should respond with Unauthorized if access token is not present', async () => {
const res = await request(app)
.post('/SASjsApi/permission')
@@ -240,20 +218,6 @@ describe('permission', () => {
expect(res.body).toEqual({})
})
it('should respond with forbidden Request (403) if client is not found', async () => {
const res = await request(app)
.post('/SASjsApi/permission')
.auth(adminAccessToken, { type: 'bearer' })
.send({
...permission,
principalType: 'client'
})
.expect(403)
expect(res.text).toEqual('Error: Client not found.')
expect(res.body).toEqual({})
})
it('should respond with forbidden Request (403) if principal type is not valid', async () => {
const res = await request(app)
.post('/SASjsApi/permission')
@@ -265,7 +229,7 @@ describe('permission', () => {
.expect(403)
expect(res.text).toEqual(
'Error: Invalid principal type. Valid types are user, group and client.'
'Error: Invalid principal type. Valid types are user or group.'
)
expect(res.body).toEqual({})
})