chore: restructured controllers

api/src/controllers/auth.ts

@@ -2,11 +2,17 @@ import { Security, Route, Tags, Example, Post, Body, Query, Hidden } from 'tsoa'
 import jwt from 'jsonwebtoken'
 import User from '../model/User'
 import { InfoJWT } from '../types'
-import { removeTokensInDB, saveTokensInDB } from '../utils'
+import {
+  generateAccessToken,
+  generateAuthCode,
+  generateRefreshToken,
+  removeTokensInDB,
+  saveTokensInDB
+} from '../utils'
 
 @Route('SASjsApi/auth')
 @Tags('Auth')
-export default class AuthController {
+export class AuthController {
   static authCodes: { [key: string]: { [key: string]: string } } = {}
   static saveCode = (userId: number, clientId: string, code: string) => {
     if (AuthController.authCodes[userId])
@@ -185,21 +191,6 @@ interface TokenResponse {
   refreshToken: string
 }
 
-export const generateAuthCode = (data: InfoJWT) =>
-  jwt.sign(data, process.env.AUTH_CODE_SECRET as string, {
-    expiresIn: '30s'
-  })
-
-export const generateAccessToken = (data: InfoJWT) =>
-  jwt.sign(data, process.env.ACCESS_TOKEN_SECRET as string, {
-    expiresIn: '1h'
-  })
-
-export const generateRefreshToken = (data: InfoJWT) =>
-  jwt.sign(data, process.env.REFRESH_TOKEN_SECRET as string, {
-    expiresIn: '1day'
-  })
-
 const verifyAuthCode = async (
   clientId: string,
   code: string

api/src/controllers/client.ts

@@ -5,7 +5,7 @@ import Client, { ClientPayload } from '../model/Client'
 @Security('bearerAuth')
 @Route('SASjsApi/client')
 @Tags('Client')
-export default class ClientController {
+export class ClientController {
   /**
    * @summary Create client with the following attributes: ClientId, ClientSecret. Admin only task.
    *

api/src/controllers/drive.ts

@@ -11,7 +11,7 @@ import {
   Patch
 } from 'tsoa'
 import { fileExists, readFile, createFile } from '@sasjs/utils'
-import { createFileTree, ExecutionController, getTreeExample } from '.'
+import { createFileTree, ExecutionController, getTreeExample } from './internal'
 
 import { FileTree, isFileTree, TreeNode } from '../types'
 import path from 'path'

api/src/controllers/group.ts

@@ -31,7 +31,7 @@ interface GroupDetailsResponse {
 @Security('bearerAuth')
 @Route('SASjsApi/group')
 @Tags('Group')
-export default class GroupController {
+export class GroupController {
   /**
    * @summary Get list of all groups (groupName and groupDescription). All users can request this.
    *

api/src/controllers/index.ts

@@ -1,4 +1,6 @@
-export * from './deploy'
+export * from './auth'
-export * from './Session'
+export * from './client'
-export * from './Execution'
+export * from './drive'
-export * from './FileUploadController'
+export * from './group'
+export * from './stp'
+export * from './user'

api/src/controllers/internal/Execution.ts

@@ -2,11 +2,11 @@ import path from 'path'
 import fs from 'fs'
 import { getSessionController } from './'
 import { readFile, fileExists, createFile } from '@sasjs/utils'
-import { configuration } from '../../package.json'
+import { configuration } from '../../../package.json'
 import { promisify } from 'util'
 import { execFile } from 'child_process'
-import { PreProgramVars, Session, TreeNode } from '../types'
+import { PreProgramVars, Session, TreeNode } from '../../types'
-import { generateFileUploadSasCode, getTmpFilesFolderPath } from '../utils'
+import { generateFileUploadSasCode, getTmpFilesFolderPath } from '../../utils'
 
 const execFilePromise = promisify(execFile)
 

api/src/controllers/internal/Session.ts

@@ -1,5 +1,5 @@
-import { Session } from '../types'
+import { Session } from '../../types'
-import { getTmpSessionsFolderPath, generateUniqueFileName } from '../utils'
+import { getTmpSessionsFolderPath, generateUniqueFileName } from '../../utils'
 import {
   deleteFolder,
   createFile,
@@ -120,7 +120,7 @@ export class SessionController {
   }
 }
 
-export const getSessionController = () => {
+export const getSessionController = (): SessionController => {
   if (process.sessionController) return process.sessionController
 
   process.sessionController = new SessionController()

api/src/controllers/internal/deploy.ts

@@ -1,5 +1,5 @@
-import { MemberType, FolderMember, ServiceMember, FileTree } from '../types'
+import { MemberType, FolderMember, ServiceMember, FileTree } from '../../types'
-import { getTmpFilesFolderPath } from '../utils/file'
+import { getTmpFilesFolderPath } from '../../utils/file'
 import { createFolder, createFile, asyncForEach } from '@sasjs/utils'
 import path from 'path'
 

api/src/controllers/internal/index.ts

@@ -0,0 +1,4 @@
+export * from './deploy'
+export * from './Session'
+export * from './Execution'
+export * from './FileUploadController'

api/src/controllers/stp.ts

@@ -11,7 +11,7 @@ import {
   Get,
   Query
 } from 'tsoa'
-import { ExecutionController } from '.'
+import { ExecutionController } from './internal'
 import { PreProgramVars } from '../types'
 import { getTmpFilesFolderPath, makeFilesNamesMap } from '../utils'
 
@@ -32,7 +32,7 @@ interface ExecuteReturnJsonResponse {
 @Security('bearerAuth')
 @Route('SASjsApi/client')
 @Tags('STP')
-export default class STPController {
+export class STPController {
   /**
    * Trigger a SAS program using it's location in the _program parameter.
    * Enable debugging using the _debug parameter.

api/src/controllers/user.ts

@@ -32,7 +32,7 @@ interface UserDetailsResponse {
 @Security('bearerAuth')
 @Route('SASjsApi/user')
 @Tags('User')
-export default class UserController {
+export class UserController {
   /**
    * @summary Get list of all users (username, displayname). All users can request this.
    *

api/src/routes/api/auth.ts

@@ -1,7 +1,7 @@
 import express from 'express'
 import mongoose from 'mongoose'
 
-import AuthController from '../../controllers/auth'
+import { AuthController } from '../../controllers/'
 import Client from '../../model/Client'
 
 import {

api/src/routes/api/client.ts

@@ -1,5 +1,5 @@
 import express from 'express'
-import ClientController from '../../controllers/client'
+import { ClientController } from '../../controllers'
 import { registerClientValidation } from '../../utils'
 
 const clientRouter = express.Router()

api/src/routes/api/drive.ts

@@ -1,5 +1,5 @@
 import express from 'express'
-import { DriveController } from '../../controllers/drive'
+import { DriveController } from '../../controllers/'
 import { getFileDriveValidation, updateFileDriveValidation } from '../../utils'
 
 const driveRouter = express.Router()

api/src/routes/api/group.ts

@@ -1,8 +1,7 @@
 import express from 'express'
-import GroupController from '../../controllers/group'
+import { GroupController } from '../../controllers/'
 import { authenticateAccessToken, verifyAdmin } from '../../middlewares'
 import { registerGroupValidation } from '../../utils'
-import userRouter from './user'
 
 const groupRouter = express.Router()
 

api/src/routes/api/spec/auth.spec.ts

@@ -2,16 +2,20 @@ import mongoose, { Mongoose } from 'mongoose'
 import { MongoMemoryServer } from 'mongodb-memory-server'
 import request from 'supertest'
 import app from '../../../app'
-import UserController from '../../../controllers/user'
+import {
-import ClientController from '../../../controllers/client'
+  UserController,
-import AuthController, {
+  ClientController,
-  generateAccessToken,
+  AuthController
-  generateAuthCode,
+} from '../../../controllers/'
-  generateRefreshToken
-} from '../../../controllers/auth'
 import { populateClients } from '../auth'
 import { InfoJWT } from '../../../types'
-import { saveTokensInDB, verifyTokenInDB } from '../../../utils'
+import {
+  generateAccessToken,
+  generateAuthCode,
+  generateRefreshToken,
+  saveTokensInDB,
+  verifyTokenInDB
+} from '../../../utils'
 
 const clientId = 'someclientID'
 const clientSecret = 'someclientSecret'

api/src/routes/api/spec/client.spec.ts

@@ -2,10 +2,8 @@ import mongoose, { Mongoose } from 'mongoose'
 import { MongoMemoryServer } from 'mongodb-memory-server'
 import request from 'supertest'
 import app from '../../../app'
-import UserController from '../../../controllers/user'
+import { UserController, ClientController } from '../../../controllers/'
-import ClientController from '../../../controllers/client'
+import { generateAccessToken, saveTokensInDB } from '../../../utils'
-import { generateAccessToken } from '../../../controllers/auth'
-import { saveTokensInDB } from '../../../utils'
 
 const client = {
   clientId: 'someclientID',

api/src/routes/api/spec/drive.spec.ts

@@ -2,13 +2,12 @@ import mongoose, { Mongoose } from 'mongoose'
 import { MongoMemoryServer } from 'mongodb-memory-server'
 import request from 'supertest'
 import app from '../../../app'
-import { getTreeExample } from '../../../controllers/deploy'
+import { UserController } from '../../../controllers/'
-import UserController from '../../../controllers/user'
+import { getTreeExample } from '../../../controllers/internal'
 import { getTmpFilesFolderPath } from '../../../utils/file'
 import { folderExists, fileExists, readFile, deleteFolder } from '@sasjs/utils'
 import path from 'path'
-import { generateAccessToken } from '../../../controllers/auth'
+import { generateAccessToken, saveTokensInDB } from '../../../utils'
-import { saveTokensInDB } from '../../../utils'
 import { FolderMember, ServiceMember } from '../../../types'
 
 const clientId = 'someclientID'

api/src/routes/api/spec/group.spec.ts

@@ -2,10 +2,8 @@ import mongoose, { Mongoose } from 'mongoose'
 import { MongoMemoryServer } from 'mongodb-memory-server'
 import request from 'supertest'
 import app from '../../../app'
-import UserController from '../../../controllers/user'
+import { UserController, GroupController } from '../../../controllers/'
-import GroupController from '../../../controllers/group'
+import { generateAccessToken, saveTokensInDB } from '../../../utils'
-import { generateAccessToken } from '../../../controllers/auth'
-import { saveTokensInDB } from '../../../utils'
 
 const clientId = 'someclientID'
 const adminUser = {

api/src/routes/api/spec/user.spec.ts

@@ -2,9 +2,8 @@ import mongoose, { Mongoose } from 'mongoose'
 import { MongoMemoryServer } from 'mongodb-memory-server'
 import request from 'supertest'
 import app from '../../../app'
-import UserController from '../../../controllers/user'
+import { UserController } from '../../../controllers/'
-import { generateAccessToken } from '../../../controllers/auth'
+import { generateAccessToken, saveTokensInDB } from '../../../utils'
-import { saveTokensInDB } from '../../../utils'
 
 const clientId = 'someclientID'
 const adminUser = {

api/src/routes/api/stp.ts

@@ -1,7 +1,7 @@
 import express from 'express'
 import { executeProgramRawValidation } from '../../utils'
-import STPController from '../../controllers/stp'
+import { STPController } from '../../controllers/'
-import { FileUploadController } from '../../controllers'
+import { FileUploadController } from '../../controllers/internal'
 
 const stpRouter = express.Router()
 

api/src/routes/api/user.ts

@@ -1,5 +1,5 @@
 import express from 'express'
-import UserController from '../../controllers/user'
+import { UserController } from '../../controllers/'
 import {
   authenticateAccessToken,
   verifyAdmin,

api/src/utils/generateAccessToken.ts

@@ -0,0 +1,7 @@
+import jwt from 'jsonwebtoken'
+import { InfoJWT } from '../types'
+
+export const generateAccessToken = (data: InfoJWT) =>
+  jwt.sign(data, process.env.ACCESS_TOKEN_SECRET as string, {
+    expiresIn: '1h'
+  })

api/src/utils/generateAuthCode.ts

@@ -0,0 +1,7 @@
+import jwt from 'jsonwebtoken'
+import { InfoJWT } from '../types'
+
+export const generateAuthCode = (data: InfoJWT) =>
+  jwt.sign(data, process.env.AUTH_CODE_SECRET as string, {
+    expiresIn: '30s'
+  })

api/src/utils/generateRefreshToken.ts

@@ -0,0 +1,7 @@
+import jwt from 'jsonwebtoken'
+import { InfoJWT } from '../types'
+
+export const generateRefreshToken = (data: InfoJWT) =>
+  jwt.sign(data, process.env.REFRESH_TOKEN_SECRET as string, {
+    expiresIn: '1day'
+  })

api/src/utils/index.ts

@@ -1,4 +1,7 @@
 export * from './file'
+export * from './generateAccessToken'
+export * from './generateAuthCode'
+export * from './generateRefreshToken'
 export * from './removeTokensInDB'
 export * from './saveTokensInDB'
 export * from './sleep'