sasjs/server
1
0
Fork 0
mirror of https://github.com/sasjs/server.git synced 2026-07-24 05:32:15 +00:00
Code Issues Projects Releases Wiki Activity

fix(api): stop overwriting a failed JS/PY/R session back to completed

Browse Source 
For JS/PY/R, processProgram sets session.state = failed (with
failureReason) itself when the interpreter process exits non-zero,
without throwing. ExecutionController.executeProgram then
unconditionally set session.state = completed right after
processProgram returned, silently overwriting that - so anything
downstream inspecting session.state (e.g. scheduleSessionDestroy's
expiresAfterMins branch) would see a crashed session mis-reported as
successful.

Guard the assignment so a failed state is never overwritten. No
effect on SAS, which sets state independently via its own spawned
process lifecycle.

Added Execution.spec.ts covering both the failure case (state stays
failed) and the success case (state still becomes completed), to
guard against regressing in either direction.
This commit is contained in:
YuryShkoda
2026-07-14 11:29:30 +03:00
parent 8b2a6155a9
commit 4858245372
2 changed files with 94 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
api/src/controllers/internal/Execution.ts
+10 -1
View File
@@ -120,7 +120,16 @@ export class ExecutionController {
: ''
// it should be deleted by scheduleSessionDestroy
session.state = SessionState.completed
//
// Guarded: for JS/PY/R, processProgram sets state to `failed` itself
// (without throwing) when the interpreter process exits non-zero - if
// we unconditionally set `completed` here we'd silently overwrite that,
// and anything downstream inspecting session.state (e.g.
// scheduleSessionDestroy's expiresAfterMins branch in Session.ts) would
// see a crashed session mis-reported as successful.
if ((session.state as SessionState) !== SessionState.failed) {
session.state = SessionState.completed
}
const resultParts = []