sasjs/server
1
0
Fork 0
mirror of https://github.com/sasjs/server.git synced 2026-04-09 23:23:13 +00:00
Code Issues Projects Releases Wiki Activity

fix: ldap issues

Browse Source 
logic fixed for updating user created by external auth provider
remove internal from AuthProviderType
replace AUTH_MECHANISM with AUTH_PROVIDERS
This commit is contained in:
Sabir Hassan
2022-10-03 21:24:10 +05:00
parent 042ed41189
commit 4d64420c45
6 changed files with 28 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
api/src/controllers/group.ts
View File

@@ -251,7 +251,7 @@ const updateUsersListInGroup = async (
message: `Can't add/remove user to '${PUBLIC_GROUP_NAME}' group.`
}
if (group.authProvider !== AuthProviderType.Internal)
if (group.authProvider)
throw {
code: 405,
status: 'Method Not Allowed',
@@ -266,7 +266,7 @@ const updateUsersListInGroup = async (
message: 'User not found.'
}
if (user.authProvider !== AuthProviderType.Internal)
if (user.authProvider)
throw {
code: 405,
status: 'Method Not Allowed',

15
api/src/controllers/user.ts
View File

@@ -299,14 +299,19 @@ const updateUser = async (
const user = await User.findOne(findBy)
if (
user?.authProvider !== AuthProviderType.Internal &&
(username !== user?.username || displayName !== user?.displayName)
) {
if (username && username !== user?.username && user?.authProvider) {
throw {
code: 405,
message:
'Can not update username and display name of user that is created by an external auth provider.'
'Can not update username of user that is created by an external auth provider.'
}
}
if (displayName && displayName !== user?.displayName && user?.authProvider) {
throw {
code: 405,
message:
'Can not update display name of user that is created by an external auth provider.'
}
}