From 54d4bf835db177362eba1b1ec94579cc3b796e37 Mon Sep 17 00:00:00 2001
From: Sabir Hassan <sabirbk06@gmail.com>
Date: Fri, 24 Jun 2022 15:50:09 +0500
Subject: [PATCH] chore: show principal type in permissions list

---
 web/src/containers/Settings/permission.tsx | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/web/src/containers/Settings/permission.tsx b/web/src/containers/Settings/permission.tsx
index 36712d4..3f060a0 100644
--- a/web/src/containers/Settings/permission.tsx
+++ b/web/src/containers/Settings/permission.tsx
@@ -38,6 +38,11 @@ const BootstrapTableCell = styled(TableCell)({
   textAlign: 'left'
 })
 
+enum PrincipalType {
+  User = 'User',
+  Group = 'Group'
+}
+
 const Permission = () => {
   const appContext = useContext(AppContext)
   const [isLoading, setIsLoading] = useState(false)
@@ -304,6 +309,7 @@ const PermissionTable = ({
           <TableRow>
             <BootstrapTableCell>Uri</BootstrapTableCell>
             <BootstrapTableCell>Principal</BootstrapTableCell>
+            <BootstrapTableCell>Type</BootstrapTableCell>
             <BootstrapTableCell>Setting</BootstrapTableCell>
             {appContext.isAdmin && (
               <BootstrapTableCell>Action</BootstrapTableCell>
@@ -317,6 +323,9 @@ const PermissionTable = ({
               <BootstrapTableCell>
                 {displayPrincipal(permission)}
               </BootstrapTableCell>
+              <BootstrapTableCell>
+                {displayPrincipalType(permission)}
+              </BootstrapTableCell>
               <BootstrapTableCell>{permission.setting}</BootstrapTableCell>
               {appContext.isAdmin && (
                 <BootstrapTableCell>
@@ -346,9 +355,11 @@ const PermissionTable = ({
 }
 
 const displayPrincipal = (permission: PermissionResponse) => {
-  if (permission.user) {
-    return permission.user?.displayName
-  } else if (permission.group) {
-    return permission.group?.name
-  }
+  if (permission.user) return permission.user?.displayName
+  if (permission.group) return permission.group?.name
+}
+
+const displayPrincipalType = (permission: PermissionResponse) => {
+  if (permission.user) return PrincipalType.User
+  if (permission.group) return PrincipalType.Group
 }