From 5b319f9ad1f941b306db6b9473a2128b2e42bf76 Mon Sep 17 00:00:00 2001
From: Sabir Hassan <sabirbk06@gmail.com>
Date: Thu, 23 Jun 2022 23:58:40 +0500
Subject: [PATCH] fix: remove duplicates principals from permission filter
 modal

---
 .../Settings/permissionFilterModal.tsx        | 22 +++++++++++++------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/web/src/containers/Settings/permissionFilterModal.tsx b/web/src/containers/Settings/permissionFilterModal.tsx
index 7f7faab..962c3da 100644
--- a/web/src/containers/Settings/permissionFilterModal.tsx
+++ b/web/src/containers/Settings/permissionFilterModal.tsx
@@ -49,13 +49,21 @@ const PermissionFilterModal = ({
   resetFilter
 }: FilterModalProps) => {
   const URIs = permissions.map((permission) => permission.uri)
-  const principals = permissions
-    .map((permission) => {
-      if (permission.user) return permission.user.displayName
-      if (permission.group) return permission.group.name
-      return ''
-    })
-    .filter((principal) => principal !== '')
+
+  // fetch all the principals from permissions array
+  let principals = permissions.map((permission) => {
+    if (permission.user) return permission.user.displayName
+    if (permission.group) return permission.group.name
+    return ''
+  })
+
+  // removes empty strings
+  principals = principals.filter((principal) => principal !== '')
+
+  // removes the duplicates
+  principals = principals.filter(
+    (value, index, self) => self.indexOf(value) === index
+  )
 
   return (
     <BootstrapDialog onClose={() => handleOpen(false)} open={open}>