From 7be77cc38aa632d4abf05386c21df0cbaa7988af Mon Sep 17 00:00:00 2001
From: Sabir Hassan <sabirbk06@gmail.com>
Date: Tue, 10 May 2022 07:05:59 +0500
Subject: [PATCH] chore: remvoe code redundancy and add specs for get
 permissions api endpoint

---
 api/src/routes/api/spec/permission.spec.ts | 58 ++++++++++++++++------
 1 file changed, 44 insertions(+), 14 deletions(-)

diff --git a/api/src/routes/api/spec/permission.spec.ts b/api/src/routes/api/spec/permission.spec.ts
index fca6a81..df2c662 100644
--- a/api/src/routes/api/spec/permission.spec.ts
+++ b/api/src/routes/api/spec/permission.spec.ts
@@ -53,6 +53,7 @@ describe('permission', () => {
   let con: Mongoose
   let mongoServer: MongoMemoryServer
   let adminAccessToken: string
+  let dbUser: UserDetailsResponse | undefined
 
   beforeAll(async () => {
     app = await appPromise
@@ -61,6 +62,7 @@ describe('permission', () => {
     con = await mongoose.connect(mongoServer.getUri())
 
     adminAccessToken = await generateSaveTokenAndCreateUser()
+    dbUser = await userController.createUser(user)
   })
 
   afterAll(async () => {
@@ -75,11 +77,10 @@ describe('permission', () => {
     })
 
     it('should respond with new permission when principalType is user', async () => {
-      const dbUser = await userController.createUser(user)
       const res = await request(app)
         .post('/SASjsApi/permission')
         .auth(adminAccessToken, { type: 'bearer' })
-        .send({ ...permission, principalId: dbUser.id })
+        .send({ ...permission, principalId: dbUser?.id })
         .expect(200)
 
       expect(res.body.permissionId).toBeTruthy()
@@ -271,16 +272,11 @@ describe('permission', () => {
   })
 
   describe('update', () => {
-    let dbUser: UserDetailsResponse | undefined
     let dbPermission: PermissionDetailsResponse | undefined
     beforeAll(async () => {
-      dbUser = await userController.createUser({
-        ...user,
-        username: 'updated username'
-      })
       dbPermission = await permissionController.createPermission({
         ...permission,
-        principalId: dbUser.id
+        principalId: dbUser?.id
       })
     })
 
@@ -351,14 +347,9 @@ describe('permission', () => {
 
   describe('delete', () => {
     it('should delete permission', async () => {
-      const dbUser = await userController.createUser({
-        ...user,
-        username: 'deleted username'
-      })
-
       const dbPermission = await permissionController.createPermission({
         ...permission,
-        principalId: dbUser.id
+        principalId: dbUser?.id
       })
       const res = await request(app)
         .delete(`/SASjsApi/permission/${dbPermission?.permissionId}`)
@@ -379,6 +370,45 @@ describe('permission', () => {
       expect(res.text).toEqual('Error: Permission is not found.')
     })
   })
+
+  describe('get', () => {
+    beforeAll(async () => {
+      await permissionController.createPermission({
+        ...permission,
+        uri: '/test-1',
+        principalId: dbUser?.id
+      })
+      await permissionController.createPermission({
+        ...permission,
+        uri: '/test-2',
+        principalId: dbUser?.id
+      })
+    })
+
+    it('should give a list of all permissions when user is admin', async () => {
+      const res = await request(app)
+        .get('/SASjsApi/permission/')
+        .auth(adminAccessToken, { type: 'bearer' })
+        .send()
+        .expect(200)
+
+      expect(res.body).toHaveLength(2)
+    })
+
+    it('should give a list of all permissions when user is not admin', async () => {
+      const accessToken = await generateSaveTokenAndCreateUser({
+        ...user,
+        username: 'get' + user.username
+      })
+      const res = await request(app)
+        .get('/SASjsApi/permission/')
+        .auth(accessToken, { type: 'bearer' })
+        .send()
+        .expect(200)
+
+      expect(res.body).toHaveLength(2)
+    })
+  })
 })
 
 const generateSaveTokenAndCreateUser = async (