diff --git a/api/src/controllers/drive.ts b/api/src/controllers/drive.ts index ddf4e7c..bf4b494 100644 --- a/api/src/controllers/drive.ts +++ b/api/src/controllers/drive.ts @@ -153,7 +153,7 @@ export class DriveController { } const getFileTree = () => { - const tree = new ExecutionController().buildDirectorytree() + const tree = new ExecutionController().buildDirectoryTree() return { status: 'success', tree } } diff --git a/api/src/controllers/internal/Execution.ts b/api/src/controllers/internal/Execution.ts index 3d54ea4..f1106f4 100644 --- a/api/src/controllers/internal/Execution.ts +++ b/api/src/controllers/internal/Execution.ts @@ -5,11 +5,15 @@ import { readFile, fileExists, createFile, moveFile } from '@sasjs/utils' import { PreProgramVars, TreeNode } from '../../types' import { generateFileUploadSasCode, getTmpFilesFolderPath } from '../../utils' +export interface ExecutionVars { + [key: string]: string | number | undefined +} + export class ExecutionController { async executeFile( programPath: string, preProgramVariables: PreProgramVars, - vars: { [key: string]: string | number | undefined }, + vars: ExecutionVars, otherArgs?: any, returnJson?: boolean ) { @@ -29,7 +33,7 @@ export class ExecutionController { async executeProgram( program: string, preProgramVariables: PreProgramVars, - vars: { [key: string]: string | number | undefined }, + vars: ExecutionVars, otherArgs?: any, returnJson?: boolean ) { @@ -55,6 +59,7 @@ export class ExecutionController { `${computed}%let ${key}=${vars[key]};\n`, '' ) + const preProgramVarStatments = ` %let _sasjs_tokenfile=${tokenFile}; %let _sasjs_username=${preProgramVariables?.username}; @@ -138,7 +143,7 @@ ${program}` : webout } - buildDirectorytree() { + buildDirectoryTree() { const root: TreeNode = { name: 'files', relativePath: '', diff --git a/api/src/controllers/internal/FileUploadController.ts b/api/src/controllers/internal/FileUploadController.ts index 53d42de..506e5a0 100644 --- a/api/src/controllers/internal/FileUploadController.ts +++ b/api/src/controllers/internal/FileUploadController.ts @@ -18,7 +18,7 @@ export class FileUploadController { //It will intercept request and generate unique uuid to be used as a subfolder name //that will store the files uploaded - public preuploadMiddleware = async (req: any, res: any, next: any) => { + public preUploadMiddleware = async (req: any, res: any, next: any) => { let session const sessionController = getSessionController() diff --git a/api/src/controllers/stp.ts b/api/src/controllers/stp.ts index b0f78ac..fd94ce7 100644 --- a/api/src/controllers/stp.ts +++ b/api/src/controllers/stp.ts @@ -1,7 +1,7 @@ import express from 'express' import path from 'path' import { Request, Security, Route, Tags, Post, Body, Get, Query } from 'tsoa' -import { ExecutionController } from './internal' +import { ExecutionController, ExecutionVars } from './internal' import { PreProgramVars } from '../types' import { getTmpFilesFolderPath, makeFilesNamesMap } from '../utils' @@ -66,7 +66,7 @@ const executeReturnRaw = async ( req: express.Request, _program: string ): Promise => { - const query = req.query as { [key: string]: string | number | undefined } + const query = req.query as ExecutionVars const sasCodePath = path .join(getTmpFilesFolderPath(), _program) diff --git a/api/src/routes/api/session.ts b/api/src/routes/api/session.ts index 436f0b2..09d0d87 100644 --- a/api/src/routes/api/session.ts +++ b/api/src/routes/api/session.ts @@ -1,6 +1,5 @@ import express from 'express' import { SessionController } from '../../controllers' -import { authenticateAccessToken } from '../../middlewares' const sessionRouter = express.Router() diff --git a/api/src/routes/api/stp.ts b/api/src/routes/api/stp.ts index 1ca4a18..9879a7c 100644 --- a/api/src/routes/api/stp.ts +++ b/api/src/routes/api/stp.ts @@ -1,5 +1,5 @@ import express from 'express' -import { executeProgramRawValidation, runSASValidation } from '../../utils' +import { executeProgramRawValidation } from '../../utils' import { STPController } from '../../controllers/' import { FileUploadController } from '../../controllers/internal' @@ -26,7 +26,7 @@ stpRouter.get('/execute', async (req, res) => { stpRouter.post( '/execute', - fileUploadController.preuploadMiddleware, + fileUploadController.preUploadMiddleware, fileUploadController.getMulterUploadObject().any(), async (req: any, res: any) => { const { error: errQ, value: query } = executeProgramRawValidation(req.query)