From 9d167abe2adb743bca161862b4561bf573182c00 Mon Sep 17 00:00:00 2001 From: Saad Jutt Date: Sat, 2 Apr 2022 05:29:34 +0500 Subject: [PATCH] fix: remove uploaded build.json from temp folder in all cases --- api/src/routes/api/drive.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/api/src/routes/api/drive.ts b/api/src/routes/api/drive.ts index bdb2e5f..71ffa4a 100644 --- a/api/src/routes/api/drive.ts +++ b/api/src/routes/api/drive.ts @@ -55,11 +55,15 @@ driveRouter.post( try { jsonContent = JSON.parse(fileContent) } catch (err) { + deleteFile(req.file.path) return res.status(400).send('File containing invalid JSON content.') } const { error, value: body } = deployValidation(jsonContent) - if (error) return res.status(400).send(error.details[0].message) + if (error) { + deleteFile(req.file.path) + return res.status(400).send(error.details[0].message) + } try { const response = await controller.deployUpload(req.file, body) @@ -82,7 +86,7 @@ driveRouter.post( res.status(statusCode).send(err) } finally { - await deleteFile(req.file.path) + deleteFile(req.file.path) } } )