dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

- Implement of promise for filter function; #1105

Open
duykhang53 wants to merge 7 commits from duykhang53/development into development
pull from: duykhang53/development
merge into: dc:development
Conversation 5 Commits 7 Files Changed 7 +16835 -52
duykhang53 commented 2019-08-15 21:53:56 +00:00 (Migrated from github.com)
Copy Link

File filter function from this commit now can be resolved from both boolean and Promise<boolean>

File filter function from this commit now can be resolved from both **boolean** and **Promise\<boolean>**
👍 1
codecov[bot] commented 2019-09-24 07:43:19 +00:00 (Migrated from github.com)
Copy Link

Codecov Report

Merging #1105 into development will increase coverage by 0.19%.
The diff coverage is 28.94%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1105      +/-   ##
===============================================
+ Coverage        34.72%   34.91%   +0.19%     
===============================================
  Files               10       10              
  Lines              550      547       -3     
  Branches            80       83       +3     
===============================================
  Hits               191      191              
+ Misses             341      336       -5     
- Partials            18       20       +2
Impacted Files Coverage Δ
src/file-upload/file-uploader.class.ts 24.63% <11.53%> (+0.44%) ⬆️
src/file-upload/file-drop.directive.ts 60% <62.5%> (-1.23%) ⬇️
src/file-upload/file-select.directive.ts 73.91% <75%> (-3.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb48f44...1e5fb25. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105?src=pr&el=h1) Report > Merging [#1105](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/fb48f4411d163a4219ffae12bfa24ce7f803e837?src=pr&el=desc) will **increase** coverage by `0.19%`. > The diff coverage is `28.94%`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105/graphs/tree.svg?width=650&token=P8ngsZQolN&height=150&src=pr)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #1105 +/- ## =============================================== + Coverage 34.72% 34.91% +0.19% =============================================== Files 10 10 Lines 550 547 -3 Branches 80 83 +3 =============================================== Hits 191 191 + Misses 341 336 -5 - Partials 18 20 +2 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-uploader.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105/diff?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdXBsb2FkZXIuY2xhc3MudHM=) | `24.63% <11.53%> (+0.44%)` | :arrow_up: | | [src/file-upload/file-drop.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105/diff?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtZHJvcC5kaXJlY3RpdmUudHM=) | `60% <62.5%> (-1.23%)` | :arrow_down: | | [src/file-upload/file-select.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105/diff?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtc2VsZWN0LmRpcmVjdGl2ZS50cw==) | `73.91% <75%> (-3.36%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105?src=pr&el=footer). Last update [fb48f44...1e5fb25](https://codecov.io/gh/valor-software/ng2-file-upload/pull/1105?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
angus151 commented 2019-10-15 02:59:50 +00:00 (Migrated from github.com)
Copy Link

Can we get this pulled?

Can we get this pulled?
duykhang53 commented 2019-10-15 04:35:33 +00:00 (Migrated from github.com)
Copy Link

Yea sure

Yea sure
angus151 commented 2019-10-15 05:13:34 +00:00 (Migrated from github.com)
Copy Link

Yea sure

Sorry, comment wasn't direct at you, but to hopefully catch the eye of one of the maintainers.

> Yea sure Sorry, comment wasn't direct at you, but to hopefully catch the eye of one of the maintainers.
angus151 (Migrated from github.com) approved these changes 2019-10-20 22:46:37 +00:00
This pull request has changes conflicting with the target branch.
  • .travis.yml
  • package-lock.json
  • package.json
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin duykhang53/development:duykhang53/development
git checkout duykhang53/development
Sign in to join this conversation.
Reviewers
No Reviewers
angus151
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
allan medjedovic root sabhas
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#1105
Delete Branch "duykhang53/development"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?