dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

Create disableMultipart option in FileUploader #224

Merged
tdonohue merged 2 commits from streaming_upload_support into development 2016-06-21 14:48:12 +00:00
Conversation 6 Commits 2 Files Changed 3
+17 -7
tdonohue commented 2016-05-26 18:01:10 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Proposed fix for #223 , based on this PR to angular-file-upload: https://github.com/nervgh/angular-file-upload/pull/602

Allows you to optionally tell FileUploader to stream the file instead of using a multipart form.

Typescript usage example:

public uploader:FileUploader = new FileUploader({url: URL, disableMultipart: true});
Proposed fix for #223 , based on this PR to `angular-file-upload`: https://github.com/nervgh/angular-file-upload/pull/602 Allows you to optionally tell `FileUploader` to stream the file instead of using a multipart form. Typescript usage example: ``` public uploader:FileUploader = new FileUploader({url: URL, disableMultipart: true}); ```
👍 1 ❤️ 2 🎉 1
valorkin commented 2016-06-06 08:29:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Looks really good for me!

Looks really good for me!
valorkin commented 2016-06-06 08:30:20 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@tdonohue can you please add documentation update, so other devs can find it?

@tdonohue can you please add documentation update, so other devs can find it?
tdonohue commented 2016-06-06 14:33:34 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@valorkin : Done! I added basic info for this new disableMultipart parameter alongside the docs for url and authToken in the readme docs

@valorkin : Done! I added basic info for this new `disableMultipart` parameter alongside the docs for `url` and `authToken` in the readme docs
👍 1
langfors commented 2016-06-21 13:39:45 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@valorkin please merge!

@valorkin please merge!
valorkin commented 2016-06-21 14:47:07 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Looks great! Thanks a lot!

Looks great! Thanks a lot!
🎉 1
ihadeed commented 2016-06-22 21:25:40 +00:00 (Migrated from github.com)
Copy Link
Copy Source

@tdonohue thank you! ❤️

@tdonohue thank you! :heart:
👍 1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
allan (Allan) medjedovic (Mihajlo Medjedovic) root sabhas (Sabir Hassan)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#224