dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

Feat RC.6 #379

Merged
adrianfaciu merged 4 commits from feat-rc6 into development 2016-09-15 07:46:23 +00:00
Conversation 10 Commits 4 Files Changed 10 +127 -114
adrianfaciu commented 2016-09-07 19:31:59 +00:00 (Migrated from github.com)
Copy Link

Working to update to RC.6 version of Angular. Currently work in progress.
Still need to update test (execution) and check if anything else is needed beside that.

Working to update to RC.6 version of Angular. **Currently work in progress.** Still need to update test (execution) and check if anything else is needed beside that.
valorkin commented 2016-09-08 11:34:26 +00:00 (Migrated from github.com)
Copy Link

PhantomJS 2.1.1 (Linux 0.0.0) ERROR Error: Missing: SyncTestZoneSpec at /home/travis/build/valor-software/ng2-file-upload/test.bundle.js:283
oO

`PhantomJS 2.1.1 (Linux 0.0.0) ERROR Error: Missing: SyncTestZoneSpec at /home/travis/build/valor-software/ng2-file-upload/test.bundle.js:283` oO
adrianfaciu commented 2016-09-08 11:50:34 +00:00 (Migrated from github.com)
Copy Link

Yes, I've seen that. I'm working with Bash on windows and for some reason PhantomJS fails to start (there are some issues opened with this). I'll try to find a fix/workaround today.

Yes, I've seen that. I'm working with Bash on windows and for some reason PhantomJS fails to start (there are some issues opened with this). I'll try to find a fix/workaround today.
Martin-Luft commented 2016-09-08 11:52:58 +00:00 (Migrated from github.com)
Copy Link

I think you should change the imports (the order is important):

require('zone.js/dist/zone');
require('zone.js/dist/long-stack-trace-zone');
require('zone.js/dist/async-test');
require('zone.js/dist/fake-async-test');
require('zone.js/dist/sync-test');
require('zone.js/dist/proxy');
require('zone.js/dist/jasmine-patch');

I think you should change the imports (the order is important): > require('zone.js/dist/zone'); > require('zone.js/dist/long-stack-trace-zone'); > require('zone.js/dist/async-test'); > require('zone.js/dist/fake-async-test'); > require('zone.js/dist/sync-test'); > require('zone.js/dist/proxy'); > require('zone.js/dist/jasmine-patch');
mktitan commented 2016-09-09 10:46:06 +00:00 (Migrated from github.com)
Copy Link

@adrianfaciu This update would be greatly appreciated. Looking forward to it.

@adrianfaciu This update would be greatly appreciated. Looking forward to it.
valorkin commented 2016-09-09 11:03:06 +00:00 (Migrated from github.com)
Copy Link

Awesome! @otelnov can you check what is left? :)

Awesome! @otelnov can you check what is left? :)
adrianfaciu commented 2016-09-10 09:36:47 +00:00 (Migrated from github.com)
Copy Link

@valorkin @otelnov I've fixed the test execution. Everything should be fine now.
This should fix #378

@valorkin @otelnov I've fixed the test execution. Everything should be fine now. This should fix #378
👍 3 🎉 1
GreenToast commented 2016-09-14 12:57:16 +00:00 (Migrated from github.com)
Copy Link

Do you also generate *.metadata.json-files to support aot-compilation? Otherwise it would result in the similar issue like ng2-bootstrap https://github.com/valor-software/ng2-bootstrap/issues/933

Do you also generate *.metadata.json-files to support aot-compilation? Otherwise it would result in the similar issue like ng2-bootstrap https://github.com/valor-software/ng2-bootstrap/issues/933
valorkin commented 2016-09-14 13:11:52 +00:00 (Migrated from github.com)
Copy Link

Not yet, but will be added

On Wed, Sep 14, 2016, 15:57 GreenToast notifications@github.com wrote:

Do you also generate *.metadata.json-files to support aot-compilation?
Similar issue at ng2-bootstrap valor-software/ng2-bootstrap#933
https://github.com/valor-software/ng2-bootstrap/issues/933

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/valor-software/ng2-file-upload/pull/379#issuecomment-247004103,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABDk4zIRI7QEXhc8dzEbRCExEW-29DTdks5qp-8sgaJpZM4J3RYx
.

Not yet, but will be added On Wed, Sep 14, 2016, 15:57 GreenToast notifications@github.com wrote: > Do you also generate *.metadata.json-files to support aot-compilation? > Similar issue at ng2-bootstrap valor-software/ng2-bootstrap#933 > https://github.com/valor-software/ng2-bootstrap/issues/933 > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > https://github.com/valor-software/ng2-file-upload/pull/379#issuecomment-247004103, > or mute the thread > https://github.com/notifications/unsubscribe-auth/ABDk4zIRI7QEXhc8dzEbRCExEW-29DTdks5qp-8sgaJpZM4J3RYx > .
otelnov commented 2016-09-15 07:44:34 +00:00 (Migrated from github.com)
Copy Link

@valorkin @adrianfaciu
https://github.com/valor-software/ng2-file-upload/pull/393

@valorkin @adrianfaciu https://github.com/valor-software/ng2-file-upload/pull/393
👍 1
valorkin commented 2016-09-15 07:47:03 +00:00 (Migrated from github.com)
Copy Link

@adrianfaciu @otelnov thank you so much!

@adrianfaciu @otelnov thank you so much!
👍 2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
allan medjedovic root sabhas
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#379
Delete Branch "feat-rc6"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?