Allow to extend classes #468

2016-10-25T23:23:19Z

DanielKucal commented

2016-10-25 23:23:19 +00:00

(Migrated from github.com)

Hi. We need to take an advantage of Object Oriented Programming brought to us by Typescript. It means (almost) all classes should be extensible, and to make classes extensible we need to avoid the private access modifiers, since child class can't not only overrwite them in themselves but also edit any method using private fields or methods without copying them all. And as we all know - copying the code is something we really don't want to do :)
That's why I've replaced all private accessors by protected to allow extending of classes. It actually changes nothing in functionality, but doesn't force developers like us to maintain individual forks, so please merge it as soon as possible. Thanks in advance!

Hi. We need to take an advantage of Object Oriented Programming brought to us by Typescript. It means (almost) all classes should be extensible, and to make classes extensible we need to avoid the `private` access modifiers, since child class can't not only overrwite them in themselves but also edit any method using `private` fields or methods without copying them all. And as we all know - copying the code is something we really don't want to do :) That's why I've replaced all `private` accessors by `protected` to allow extending of classes. It actually changes nothing in functionality, but doesn't force developers like us to maintain individual forks, so please merge it as soon as possible. Thanks in advance!

valorkin commented

2017-01-17 13:06:59 +00:00

(Migrated from github.com)

Awesome thank you!

👍 1

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#468