Effective default queue limit of 0 #58

2016-02-12T19:15:39Z

bensgroi commented

2016-02-12 19:15:39 +00:00

(Migrated from github.com)

If you don't set the queueLimit manually, then it's undefined, so the queueLimitFilter never allows any files by default. I modified the filter to ignore the queueLimit if it's undefined.

sylvaindumont commented

2016-02-17 22:08:15 +00:00

(Migrated from github.com)

I have exactly the same problem, without this fix, files are never pushed to the queue and the project is unusable.
@bensgroi 👍
@valorkin this PR definitely need a merge

I have exactly the same problem, without this fix, files are never pushed to the queue and the project is unusable. @bensgroi :+1: @valorkin this PR definitely need a merge

valorkin commented

2016-02-18 08:41:16 +00:00

(Migrated from github.com)

@buchslava please check this PR locally and merge if all fine

nikkwong commented

2016-02-26 09:09:00 +00:00

(Migrated from github.com)

When will this be available?

sylvaindumont commented

2016-02-29 17:53:11 +00:00

(Migrated from github.com)

@valorkin @buchslava
This project is unusable without this pr, and this pr has no side effect (I'm testing it for 12 days).

Please merge it.

@valorkin @buchslava This project is unusable without this pr, and this pr has no side effect (I'm testing it for 12 days). Please merge it.

valorkin commented

2016-02-29 18:41:46 +00:00

(Migrated from github.com)

OK, I will do

On Mon, 29 Feb 2016, 19:53 Sylvain Dumont, notifications@github.com wrote:

@valorkin https://github.com/valorkin @buchslava
https://github.com/buchslava
This project is unusable without this pr, and this pr has no side effect
(I'm testing it for 12 days).

Please merge it.

—
Reply to this email directly or view it on GitHub
https://github.com/valor-software/ng2-file-upload/pull/58#issuecomment-190309131
.

OK, I will do On Mon, 29 Feb 2016, 19:53 Sylvain Dumont, notifications@github.com wrote: > @valorkin https://github.com/valorkin @buchslava > https://github.com/buchslava > This project is unusable without this pr, and this pr has no side effect > (I'm testing it for 12 days). > > Please merge it. > > — > Reply to this email directly or view it on GitHub > https://github.com/valor-software/ng2-file-upload/pull/58#issuecomment-190309131 > .

zcsongor commented

2016-03-08 08:27:21 +00:00

(Migrated from github.com)

any news about this?

tom10271 commented

2016-03-10 08:50:31 +00:00

(Migrated from github.com)

This bug burns developer's time on figuring out what is going on.

Project members please notice that this project cannot use completely if developer do not provide queueLimit.

Merge it ASAP please.

This bug burns developer's time on figuring out what is going on. Project members please notice that this project cannot use completely if developer do not provide `queueLimit`. Merge it ASAP please.

tom10271 commented

2016-03-10 08:54:22 +00:00

(Migrated from github.com)

@zcsongor try to set queueLimit with an integer larger than number of files you want to queue up.

private uploader: FileUploader = new FileUploader({
    queueLimit: 999
})

or

this.uploader.queueLimit = 999;

should temporarily solve the issue. God I was thinking what I have done is wrong and this tiny bug cost me an hour of time, it is especially confusing when you are using the same piece of Typescript and HTML as Demo yet your own one never work....

@zcsongor try to set `queueLimit` with an integer larger than number of files you want to queue up. ``` private uploader: FileUploader = new FileUploader({ queueLimit: 999 }) ``` or ``` this.uploader.queueLimit = 999; ``` should temporarily solve the issue. God I was thinking what I have done is wrong and this tiny bug cost me an hour of time, it is especially confusing when you are using the same piece of Typescript and HTML as Demo yet your own one never work....

valorkin commented

2016-05-11 16:17:44 +00:00

(Migrated from github.com)

Thanks a lot! :)

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#58