dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

[On behalf of Lexmark]: Add export of FileLikeObject to allow callbac… #619

Merged
markmaynard merged 1 commits from development into development 2017-03-01 21:28:58 +00:00
Conversation 5 Commits 1 Files Changed 1
+1
markmaynard commented 2017-02-06 14:03:56 +00:00 (Migrated from github.com)
Copy Link
Copy Source

…k to function

Fixes issue https://github.com/valor-software/ng2-file-upload/issues/41

…k to function Fixes issue https://github.com/valor-software/ng2-file-upload/issues/41
👍 1
codecov-io commented 2017-02-06 14:12:08 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Codecov Report

Merging #619 into development will not impact coverage.

@@             Coverage Diff              @@
##           development     #619   +/-   ##
============================================
  Coverage        33.08%   33.08%           
============================================
  Files               10       10           
  Lines              547      547           
  Branches            70       70           
============================================
  Hits               181      181           
  Misses             363      363           
  Partials             3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf12851...aa28497. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/619?src=pr&el=h1) Report > Merging [#619](https://codecov.io/gh/valor-software/ng2-file-upload/pull/619?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/cf12851e1d910a693c2429052815f6520806681e?src=pr&el=desc) will **not impact** coverage. ```diff @@ Coverage Diff @@ ## development #619 +/- ## ============================================ Coverage 33.08% 33.08% ============================================ Files 10 10 Lines 547 547 Branches 70 70 ============================================ Hits 181 181 Misses 363 363 Partials 3 3 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/619?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/619?src=pr&el=footer). Last update [cf12851...aa28497](https://codecov.io/gh/valor-software/ng2-file-upload/compare/cf12851e1d910a693c2429052815f6520806681e...aa284975f5d8bcf229a90dc23855e916a7b34d89?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
gabskoro commented 2017-02-16 07:49:44 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Just what I need now. @valorkin can you take a look, please?

Just what I need now. @valorkin can you take a look, please?
👍 1
Chris-Devine commented 2017-03-01 16:24:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Can this be merged into development please? i need it to use "onWhenAddingFileFailed" function as one of the parameters is a FileLikeObject

Can this be merged into development please? i need it to use "onWhenAddingFileFailed" function as one of the parameters is a FileLikeObject
valorkin commented 2017-03-01 21:29:26 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Thanks, can not get here for a while :(

Thanks, can not get here for a while :(
markmaynard commented 2017-03-20 13:02:43 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Any chance of a new release with this change in it?

Any chance of a new release with this change in it?
👍 2
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
allan (Allan) medjedovic (Mihajlo Medjedovic) root sabhas (Sabir Hassan)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#619