dc/ng2-file-upload
4
0
Fork 0
Code Issues 395 Pull Requests 27 Packages Projects Releases 4 Wiki Activity

Add rawFile in the file like object #649

Merged
gabskoro merged 1 commits from feature/file-like-object-with-raw-file into development 2017-10-07 09:07:52 +00:00
Conversation 1 Commits 1 Files Changed 1
+2
gabskoro commented 2017-02-28 09:37:41 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Sometimes you need more info about the uploaded file and it would be ok to have the rawFile in the fileLikeObject when setting a custom filter.

I need it to get the image width and height, that's why I needed promise support #648

Sometimes you need more info about the uploaded file and it would be ok to have the rawFile in the `fileLikeObject` when setting a custom filter. I need it to get the image width and height, that's why I needed promise support #648
codecov-io commented 2017-02-28 09:42:33 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Codecov Report

Merging #649 into development will increase coverage by 17.73%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##           development     #649       +/-   ##
================================================
+ Coverage        33.08%   50.81%   +17.73%     
================================================
  Files               10       10               
  Lines              547      549        +2     
  Branches            70       74        +4     
================================================
+ Hits               181      279       +98     
+ Misses             363      269       -94     
+ Partials             3        1        -2
Impacted Files Coverage Δ
src/file-upload/file-like-object.class.ts 45% <0%> (+13.42%) ⬆️
src/file-upload/file-item.class.ts 27.27% <0%> (+5.05%) ⬆️
scripts/matchers.ts 57.14% <0%> (+14.28%) ⬆️
src/file-upload/file-uploader.class.ts 40.6% <0%> (+15.41%) ⬆️
src/file-upload/file-type.class.ts 53.84% <0%> (+30.76%) ⬆️
src/file-upload/file-select.directive.ts 95.45% <0%> (+40.9%) ⬆️
src/file-upload/file-drop.directive.ts 87.03% <0%> (+49.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf12851...e08f80e. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=h1) Report > Merging [#649](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/cf12851e1d910a693c2429052815f6520806681e?src=pr&el=desc) will **increase** coverage by `17.73%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649/graphs/tree.svg?token=P8ngsZQolN&width=650&height=150&src=pr)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #649 +/- ## ================================================ + Coverage 33.08% 50.81% +17.73% ================================================ Files 10 10 Lines 547 549 +2 Branches 70 74 +4 ================================================ + Hits 181 279 +98 + Misses 363 269 -94 + Partials 3 1 -2 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-like-object.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtbGlrZS1vYmplY3QuY2xhc3MudHM=) | `45% <0%> (+13.42%)` | :arrow_up: | | [src/file-upload/file-item.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtaXRlbS5jbGFzcy50cw==) | `27.27% <0%> (+5.05%)` | :arrow_up: | | [scripts/matchers.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree#diff-c2NyaXB0cy9tYXRjaGVycy50cw==) | `57.14% <0%> (+14.28%)` | :arrow_up: | | [src/file-upload/file-uploader.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdXBsb2FkZXIuY2xhc3MudHM=) | `40.6% <0%> (+15.41%)` | :arrow_up: | | [src/file-upload/file-type.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdHlwZS5jbGFzcy50cw==) | `53.84% <0%> (+30.76%)` | :arrow_up: | | [src/file-upload/file-select.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtc2VsZWN0LmRpcmVjdGl2ZS50cw==) | `95.45% <0%> (+40.9%)` | :arrow_up: | | [src/file-upload/file-drop.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtZHJvcC5kaXJlY3RpdmUudHM=) | `87.03% <0%> (+49.3%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=footer). Last update [cf12851...e08f80e](https://codecov.io/gh/valor-software/ng2-file-upload/pull/649?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
dependencies
Pull requests that update a dependency file
 duplicate
enhancement
greenkeeper
help wanted
in progress
invalid
need to reproduce
question
status: pending
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
allan (Allan) medjedovic (Mihajlo Medjedovic) root sabhas (Sabir Hassan)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#649