Emit event when file is selected #786

2017-05-08T21:56:59Z

albpara commented

2017-05-08 21:56:59 +00:00

(Migrated from github.com)

No description provided.

adrianfaciu commented

2017-10-02 14:52:40 +00:00

(Migrated from github.com)

Hello, we're working to get this into a better shape and reviewing the PRs.

Can you please rebase to latest and:

update the documentation and sample also
add some tests for this new output

Hello, we're working to get this into a better shape and reviewing the PRs. Can you please rebase to latest and: - update the documentation and sample also - add some tests for this new output

balr404 commented

2017-10-05 23:41:36 +00:00

(Migrated from github.com)

We also expecting the above change made by albpara need to be pushed. (i.eEmit event when file is selected) . Appreciate if you guys commit his change.

codecov[bot] commented

2017-10-07 08:59:54 +00:00

(Migrated from github.com)

Codecov Report

Merging #786 into development will increase coverage by 0.05%.
The diff coverage is 66.66%.

@@               Coverage Diff               @@
##           development     #786      +/-   ##
===============================================
+ Coverage        35.18%   35.23%   +0.05%     
===============================================
  Files               10       10              
  Lines              540      542       +2     
  Branches            76       77       +1     
===============================================
+ Hits               190      191       +1     
  Misses             333      333              
- Partials            17       18       +1

Impacted Files	Coverage Δ
src/file-upload/file-select.directive.ts	`77.27% <66.66%> (-2.73%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898f297...57b2d07. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786?src=pr&el=h1) Report > Merging [#786](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/898f297967ec43b98ed2281cc1b0baa9cf7f9994?src=pr&el=desc) will **increase** coverage by `0.05%`. > The diff coverage is `66.66%`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786/graphs/tree.svg?token=P8ngsZQolN&src=pr&height=150&width=650)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #786 +/- ## =============================================== + Coverage 35.18% 35.23% +0.05% =============================================== Files 10 10 Lines 540 542 +2 Branches 76 77 +1 =============================================== + Hits 190 191 +1 Misses 333 333 - Partials 17 18 +1 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-select.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtc2VsZWN0LmRpcmVjdGl2ZS50cw==) | `77.27% <66.66%> (-2.73%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786?src=pr&el=footer). Last update [898f297...57b2d07](https://codecov.io/gh/valor-software/ng2-file-upload/pull/786?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#786