Added onFileDrop() event to documentation #857

2017-08-01T22:09:36Z

joshterrill commented

2017-08-01 22:09:36 +00:00

(Migrated from github.com)

In case anyone wants to use the onFileDrop event to handle the files in their own way, I've added it to the documentation. I ran into a situation where I wanted to add some custom logic around file uploading, so I added onFileDrop() to my element in order to grab the list of files.

In case anyone wants to use the onFileDrop event to handle the files in their own way, I've added it to the documentation. I ran into a situation where I wanted to add some custom logic around file uploading, so I added `onFileDrop()` to my element in order to grab the list of files.

adrianfaciu commented

2017-10-02 14:50:40 +00:00

(Migrated from github.com)

Thanks for this contribution. We're working to get this into a better shape. If you have any other contributions they will be welcomed 😉

codecov[bot] commented

2017-10-02 14:52:24 +00:00

(Migrated from github.com)

Codecov Report

Merging #857 into development will increase coverage by 3.24%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #857      +/-   ##
===============================================
+ Coverage        32.22%   35.47%   +3.24%     
===============================================
  Files               10       10              
  Lines              540      530      -10     
  Branches            70       74       +4     
===============================================
+ Hits               174      188      +14     
+ Misses             363      325      -38     
- Partials             3       17      +14

Impacted Files	Coverage Δ
scripts/matchers.ts	`33.33% <0%> (-9.53%)`	⬇️
src/file-upload/file-like-object.class.ts	`23.52% <0%> (-8.05%)`	⬇️
src/file-upload/file-item.class.ts	`21.42% <0%> (-0.8%)`	⬇️
src/file-upload/file-uploader.class.ts	`25% <0%> (-0.19%)`	⬇️
src/file-upload/file-drop.directive.ts	`61.22% <0%> (+28.57%)`	⬆️
src/file-upload/file-select.directive.ts	`80% <0%> (+30%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41759be...28d98bc. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=h1) Report > Merging [#857](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/41759be974625bc9821ea87860d7828505bca9f3?src=pr&el=desc) will **increase** coverage by `3.24%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857/graphs/tree.svg?src=pr&token=P8ngsZQolN&width=650&height=150)](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #857 +/- ## =============================================== + Coverage 32.22% 35.47% +3.24% =============================================== Files 10 10 Lines 540 530 -10 Branches 70 74 +4 =============================================== + Hits 174 188 +14 + Misses 363 325 -38 - Partials 3 17 +14 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [scripts/matchers.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=tree#diff-c2NyaXB0cy9tYXRjaGVycy50cw==) | `33.33% <0%> (-9.53%)` | :arrow_down: | | [src/file-upload/file-like-object.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtbGlrZS1vYmplY3QuY2xhc3MudHM=) | `23.52% <0%> (-8.05%)` | :arrow_down: | | [src/file-upload/file-item.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtaXRlbS5jbGFzcy50cw==) | `21.42% <0%> (-0.8%)` | :arrow_down: | | [src/file-upload/file-uploader.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdXBsb2FkZXIuY2xhc3MudHM=) | `25% <0%> (-0.19%)` | :arrow_down: | | [src/file-upload/file-drop.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtZHJvcC5kaXJlY3RpdmUudHM=) | `61.22% <0%> (+28.57%)` | :arrow_up: | | [src/file-upload/file-select.directive.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtc2VsZWN0LmRpcmVjdGl2ZS50cw==) | `80% <0%> (+30%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=footer). Last update [41759be...28d98bc](https://codecov.io/gh/valor-software/ng2-file-upload/pull/857?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#857