Expand compression mime types #927

Merged

Amos47 merged 1 commits from development into development 2017-12-09 21:07:50 +00:00

Conversation 1 Commits 1 Files Changed 1

+11 -2

Amos47 commented 2017-11-18 01:05:07 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Problem

We want to allow users to upload zip files when interacting with this module.
Found an open issue.
closes https://github.com/valor-software/ng2-file-upload/issues/885

Solution

We are looking to expand the options here within the FileType class.

Bonus

Using the right class (FileLikeObject) for the file input parameter.

## Problem We want to allow users to upload zip files when interacting with this module. Found an open issue. closes https://github.com/valor-software/ng2-file-upload/issues/885 ## Solution We are looking to expand the options here within the `FileType` class. ## Bonus Using the right class (`FileLikeObject`) for the `file` input parameter.

👍 2

codecov[bot] commented 2017-11-18 01:10:51 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Codecov Report

Merging #927 into development will not change coverage.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           development     #927   +/-   ##
============================================
  Coverage        34.72%   34.72%           
============================================
  Files               10       10           
  Lines              550      550           
  Branches            80       80           
============================================
  Hits               191      191           
  Misses             341      341           
  Partials            18       18

Impacted Files	Coverage Δ
src/file-upload/file-type.class.ts	23.07% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d97b76...7d25b57. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/927?src=pr&el=h1) Report > Merging [#927](https://codecov.io/gh/valor-software/ng2-file-upload/pull/927?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/0d97b76228526befc1a9f752fbaeed8c856cdabd?src=pr&el=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/valor-software/ng2-file-upload/pull/927?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #927 +/- ## ============================================ Coverage 34.72% 34.72% ============================================ Files 10 10 Lines 550 550 Branches 80 80 ============================================ Hits 191 191 Misses 341 341 Partials 18 18 ``` | [Impacted Files](https://codecov.io/gh/valor-software/ng2-file-upload/pull/927?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/file-upload/file-type.class.ts](https://codecov.io/gh/valor-software/ng2-file-upload/pull/927?src=pr&el=tree#diff-c3JjL2ZpbGUtdXBsb2FkL2ZpbGUtdHlwZS5jbGFzcy50cw==) | `23.07% <100%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/927?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/927?src=pr&el=footer). Last update [0d97b76...7d25b57](https://codecov.io/gh/valor-software/ng2-file-upload/pull/927?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

dependencies

Pull requests that update a dependency file

duplicate

enhancement

greenkeeper

help wanted

in progress

invalid

need to reproduce

question

status: pending

wontfix

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

allan (Allan) medjedovic (Mihajlo Medjedovic) root sabhas (Sabir Hassan)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#927