Updated Readme for easier implementation #939

Merged

mattmcsparran merged 1 commits from patch-1 into development 2017-12-09 21:06:15 +00:00

Conversation 2 Commits 1 Files Changed 1

+24

mattmcsparran commented 2017-12-09 17:43:24 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Updated to show what needs to be imported for a project to work like the demo. The documentation is a little lacking, and while someone can find the information by looking at the demo, I'd suggest it being right out in the open like this. If anything needs to be changed or altered, please let me know.

Updated to show what needs to be imported for a project to work like the demo. The documentation is a little lacking, and while someone can find the information by looking at the demo, I'd suggest it being right out in the open like this. If anything needs to be changed or altered, please let me know.

codecov[bot] commented 2017-12-09 17:50:38 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Codecov Report

Merging #939 into development will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           development     #939   +/-   ##
============================================
  Coverage        34.72%   34.72%           
============================================
  Files               10       10           
  Lines              550      550           
  Branches            80       80           
============================================
  Hits               191      191           
  Misses             341      341           
  Partials            18       18

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4bed8a...502789d. Read the comment docs.

# [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/939?src=pr&el=h1) Report > Merging [#939](https://codecov.io/gh/valor-software/ng2-file-upload/pull/939?src=pr&el=desc) into [development](https://codecov.io/gh/valor-software/ng2-file-upload/commit/d4bed8a045171ead4f91b83329f494f428710b97?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/valor-software/ng2-file-upload/pull/939?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## development #939 +/- ## ============================================ Coverage 34.72% 34.72% ============================================ Files 10 10 Lines 550 550 Branches 80 80 ============================================ Hits 191 191 Misses 341 341 Partials 18 18 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/939?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/valor-software/ng2-file-upload/pull/939?src=pr&el=footer). Last update [d4bed8a...502789d](https://codecov.io/gh/valor-software/ng2-file-upload/pull/939?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

adrianfaciu commented 2017-12-09 21:06:08 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Great, thanks 👍

Great, thanks 👍

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

dependencies

Pull requests that update a dependency file

duplicate

enhancement

greenkeeper

help wanted

in progress

invalid

need to reproduce

question

status: pending

wontfix

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

allan (Allan) medjedovic (Mihajlo Medjedovic) root sabhas (Sabir Hassan)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: dc/ng2-file-upload#939