fix: file upload with sasjs server type, json not parsed

fix: updating example.html to use v4 of the adapter
Merge pull request #813 from sasjs/sasjs-job-execute
2026-01-02 18:20:06 +00:00 · 2023-06-22 12:48:40 +02:00 · 2023-06-22 08:56:32 +01:00 · 2023-06-15 16:08:08 +02:00 · 2023-06-14 15:08:11 +02:00
3 changed files with 6 additions and 4 deletions
--- a/example.html
+++ b/example.html
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html>
  <head>
-    <script src="https://cdn.jsdelivr.net/combine/npm/chart.js@2.9.3,npm/jquery@3.5.1,npm/@sasjs/adapter@1"></script> 
+    <script src="https://cdn.jsdelivr.net/combine/npm/chart.js@2.9.3,npm/jquery@3.5.1,npm/@sasjs/adapter@4"></script> 
    <script>
      var sasJs = new SASjs.default({
         appLoc: "/Public/app/readme"
--- a/src/job-execution/FileUploader.ts
+++ b/src/job-execution/FileUploader.ts
@@ -101,7 +101,7 @@ export class FileUploader extends BaseJobExecutor {
                    : res.result
                break
            }
-          } else if (this.serverType !== ServerType.Sasjs) {
+          } else {
            jsonResponse =
              typeof res.result === 'string'
                ? getValidJson(res.result)
--- a/src/job-execution/SasjsJobExecutor.ts
+++ b/src/job-execution/SasjsJobExecutor.ts
@@ -93,8 +93,10 @@ export class SasjsJobExecutor extends BaseJobExecutor {
            )
          }

-          const { result } = res.result
-          if (result && result.trim()) res.result = getValidJson(result)
+          const { result } = res
+
+          if (result && typeof result === 'string' && result.trim())
+            res.result = getValidJson(result)

          this.requestClient!.appendRequest(res, sasJob, config.debug)
Author	SHA1	Message	Date
Mihajlo Medjedovic	a4aaeba31c	fix: file upload with sasjs server type, json not parsed	2023-06-22 12:48:40 +02:00
Allan Bowe	c0f78d0c1e	fix: updating example.html to use v4 of the adapter	2023-06-22 08:56:32 +01:00
Mihajlo Medjedovic	7d826685f7	Merge pull request #813 from sasjs/sasjs-job-execute fix: issue with parsing json in sasjs job executor	2023-06-15 16:08:08 +02:00
Mihajlo Medjedovic	f42f6bca00	fix: issue with parsing json in sasjs job executor	2023-06-14 15:08:11 +02:00