Merge pull request #156 from sasjs/fix

fix(job execute): details for failing job

.github/workflows/build.yml

@@ -27,16 +27,6 @@ jobs:
         run: npm run lint
       - name: Run unit tests
         run: npm test
-        env:
-          CI: true
-          CLIENT: ${{secrets.CLIENT}}
-          SECRET: ${{secrets.SECRET}}
-          SAS_USERNAME: ${{secrets.SAS_USERNAME}}
-          SAS_PASSWORD: ${{secrets.SAS_PASSWORD}}
-          SERVER_URL: ${{secrets.SERVER_URL}}
-          SERVER_TYPE: ${{secrets.SERVER_TYPE}}
-          ACCESS_TOKEN: ${{secrets.ACCESS_TOKEN}}
-          REFRESH_TOKEN: ${{secrets.REFRESH_TOKEN}}
       - name: Build Package
         run: npm run package:lib
         env:

package-lock.json

@@ -3688,12 +3688,6 @@
         "is-obj": "^2.0.0"
       }
     },
-    "dotenv": {
-      "version": "8.2.0",
-      "resolved": "https://registry.npmjs.org/dotenv/-/dotenv-8.2.0.tgz",
-      "integrity": "sha512-8sJ78ElpbDJBHNeBzUbUVLsqKdccaa/BXF1uPTw3GrvQTBgrQrtObr2mUrE38vzYd8cEv+m/JBfDLioYcfXoaw==",
-      "dev": true
-    },
     "duplexer2": {
       "version": "0.1.4",
       "resolved": "https://registry.npmjs.org/duplexer2/-/duplexer2-0.1.4.tgz",

package.json

@@ -39,7 +39,6 @@
     "@types/isomorphic-fetch": "0.0.35",
     "@types/jest": "^26.0.15",
     "cp": "^0.2.0",
-    "dotenv": "^8.2.0",
     "jest": "^25.5.4",
     "path": "^0.12.7",
     "rimraf": "^3.0.2",

src/SASViyaApiClient.ts

@@ -574,7 +574,7 @@ export class SASViyaApiClient {
       }
 
       if (jobStatus === 'failed' || jobStatus === 'error') {
-        return Promise.reject({ error: currentJob.error, log })
+        return Promise.reject({ job: currentJob, log })
       }
 
       let resultLink

src/test/SessionManager.spec.ts

@@ -1,38 +0,0 @@
-import dotenv from 'dotenv'
-import { SessionManager } from '../SessionManager'
-import { CsrfToken } from '../types'
-
-describe('SessionManager', () => {
-  const setCsrfToken = jest
-    .fn()
-    .mockImplementation((csrfToken: CsrfToken) => console.log(csrfToken))
-
-  beforeAll(() => {
-      dotenv.config()
-  })
-
-  it('should instantiate', () => {
-    const sessionManager = new SessionManager(
-      'http://test-server.com',
-      'test context',
-      setCsrfToken
-    )
-
-    expect(sessionManager).toBeInstanceOf(SessionManager)
-    expect(sessionManager.debug).toBeFalsy()
-    expect((sessionManager as any).serverUrl).toEqual('http://test-server.com')
-    expect((sessionManager as any).contextName).toEqual('test context')
-  })
-
-  it('should set the debug flag', () => {
-    const sessionManager = new SessionManager(
-      'http://test-server.com',
-      'test context',
-      setCsrfToken
-    )
-
-    sessionManager.debug = true
-
-    expect(sessionManager.debug).toBeTruthy()
-  })
-})