chore(*): add tests for SessionManager

chore(deps-dev): bump terser-webpack-plugin from 4.2.2 to 4.2.3

.github/workflows/build.yml

@@ -27,6 +27,16 @@ jobs:
         run: npm run lint
       - name: Run unit tests
         run: npm test
+        env:
+          CI: true
+          CLIENT: ${{secrets.CLIENT}}
+          SECRET: ${{secrets.SECRET}}
+          SAS_USERNAME: ${{secrets.SAS_USERNAME}}
+          SAS_PASSWORD: ${{secrets.SAS_PASSWORD}}
+          SERVER_URL: ${{secrets.SERVER_URL}}
+          SERVER_TYPE: ${{secrets.SERVER_TYPE}}
+          ACCESS_TOKEN: ${{secrets.ACCESS_TOKEN}}
+          REFRESH_TOKEN: ${{secrets.REFRESH_TOKEN}}
       - name: Build Package
         run: npm run package:lib
         env:

PULL_REQUEST_TEMPLATE.md

@@ -14,4 +14,5 @@ What code changes have been made to achieve the intent.
 
 - [ ] Code is formatted correctly (`npm run lint:fix`).
 - [ ] All unit tests are passing (`npm test`).
+- [ ] All `sasjs-tests` unit tests are passing (`npm test`).
 - [ ] All `sasjs-tests` are passing (instructions available [here](https://github.com/sasjs/adapter/blob/master/sasjs-tests/README.md)).

package.json

@@ -37,15 +37,16 @@
   "license": "ISC",
   "devDependencies": {
     "@types/isomorphic-fetch": "0.0.35",
-    "@types/jest": "^26.0.14",
+    "@types/jest": "^26.0.15",
     "cp": "^0.2.0",
+    "dotenv": "^8.2.0",
     "jest": "^25.5.4",
     "path": "^0.12.7",
     "rimraf": "^3.0.2",
-    "semantic-release": "^17.1.2",
-    "terser-webpack-plugin": "^4.2.2",
+    "semantic-release": "^17.2.3",
+    "terser-webpack-plugin": "^4.2.3",
     "ts-jest": "^25.5.1",
-    "ts-loader": "^8.0.4",
+    "ts-loader": "^8.0.11",
     "tslint": "^6.1.3",
     "tslint-config-prettier": "^1.18.0",
     "typedoc": "^0.17.8",
@@ -53,7 +54,7 @@
     "typedoc-plugin-external-module-name": "^4.0.3",
     "typescript": "^3.9.7",
     "webpack": "^4.44.2",
-    "webpack-cli": "^3.3.12"
+    "webpack-cli": "^4.2.0"
   },
   "main": "index.js",
   "dependencies": {

src/SASViyaApiClient.ts

@@ -164,9 +164,9 @@ export class SASViyaApiClient {
     for (const promise of promises) results.push(await promise())
 
     results.forEach((result: any, index: number) => {
-      if (result && result.body && result.body.details) {
+      if (result && result.error && result.error.details) {
         try {
-          const resultParsed = JSON.parse(result.body.details)
+          const resultParsed = result.error.details
 
           if (resultParsed && resultParsed.body) {
             let sysUserId = ''

src/test/SessionManager.spec.ts

@@ -0,0 +1,38 @@
+import dotenv from 'dotenv'
+import { SessionManager } from '../SessionManager'
+import { CsrfToken } from '../types'
+
+describe('SessionManager', () => {
+  const setCsrfToken = jest
+    .fn()
+    .mockImplementation((csrfToken: CsrfToken) => console.log(csrfToken))
+
+  beforeAll(() => {
+      dotenv.config()
+  })
+
+  it('should instantiate', () => {
+    const sessionManager = new SessionManager(
+      'http://test-server.com',
+      'test context',
+      setCsrfToken
+    )
+
+    expect(sessionManager).toBeInstanceOf(SessionManager)
+    expect(sessionManager.debug).toBeFalsy()
+    expect((sessionManager as any).serverUrl).toEqual('http://test-server.com')
+    expect((sessionManager as any).contextName).toEqual('test context')
+  })
+
+  it('should set the debug flag', () => {
+    const sessionManager = new SessionManager(
+      'http://test-server.com',
+      'test context',
+      setCsrfToken
+    )
+
+    sessionManager.debug = true
+
+    expect(sessionManager.debug).toBeTruthy()
+  })
+})