1
0
mirror of https://github.com/sasjs/adapter.git synced 2026-01-03 10:40:06 +00:00

Compare commits

...

9 Commits

Author SHA1 Message Date
Allan Bowe
173e9746b1 Merge pull request #78 from sasjs/issue77
Issue77
2020-09-11 10:24:02 +02:00
Krishna Acondy
036f1203e3 Merge branch 'master' into issue77 2020-09-11 09:05:27 +01:00
Krishna Acondy
302ceb0cb1 Merge pull request #79 from sasjs/run-tests-ci
chore(ci): run unit tests as part of build
2020-09-11 09:05:09 +01:00
Krishna Acondy
e209902c1d chore(*): add code style section to doc 2020-09-11 08:28:22 +01:00
Krishna Acondy
e897037c8b chore(*): fix code formatting 2020-09-11 08:20:39 +01:00
Krishna Acondy
c6857e857c chore(ci): run unit tests as part of build 2020-09-11 08:07:37 +01:00
Krishna Acondy
49b25555fc Merge branch 'master' into issue77 2020-09-11 07:59:52 +01:00
Mihajlo Medjedovic
e642264442 fix: execute script passing debug from global config 2020-09-10 22:58:50 +02:00
Mihajlo Medjedovic
d3738ad5cd fix: waitForSession accessToken not passed 2020-09-10 20:42:14 +02:00
4 changed files with 23 additions and 2 deletions

View File

@@ -25,6 +25,8 @@ jobs:
run: npm ci
- name: Check code style
run: npm run lint
- name: Run unit tests
run: npm test
- name: Build Package
run: npm run package:lib
env:

View File

@@ -2,6 +2,23 @@
Contributions to SASjs are very welcome! When making a PR, test cases should be included.
## Code Style
This repository uses `Prettier` to ensure a uniform code style.
If you are using VS Code for development, you can automatically fix your code to match the style as follows:
- Install the `Prettier` extension for VS Code.
- Open your `settings.json` file by choosing 'Preferences: Open Settings (JSON)' from the command palette.
- Add the following items to the JSON.
```
"editor.formatOnSave": true,
"editor.formatOnPaste": true,
```
If you are using another editor, or are unable to install the extension, you can run `npm run lint:fix` to fix the formatting after you've made your changes.
## Testing
This repository contains a suite of tests built using [@sasjs/test-framework](https://github.com/sasjs/test-framework).
Detailed instructions for creating and running the tests can be found [here](https://github.com/sasjs/adapter/blob/master/sasjs-tests/README.md).

View File

@@ -194,7 +194,9 @@ export default class SASjs {
linesOfCode,
contextName,
accessToken,
silent
silent,
null,
this.sasjsConfig.debug
)
}

View File

@@ -69,7 +69,7 @@ export class SessionManager {
createSessionRequest
)
await this.waitForSession(createdSession, etag)
await this.waitForSession(createdSession, etag, accessToken)
this.sessions.push(createdSession)
return createdSession
}