fix: sasjs-tests are passing on sas9 except one

chore: update README
Thanks @saramartinelli1992 https://github.com/sasjs/adapter/issues/781#issuecomment-1420943632
2026-01-02 10:10:06 +00:00 · 2023-02-09 22:04:47 +05:00 · 2023-02-07 15:20:10 +00:00 · 2023-02-01 10:23:29 +00:00 · 2023-01-31 23:08:56 +05:00 · 2023-01-31 23:05:54 +05:00
6 changed files with 3011 additions and 370 deletions
--- a/README.md
+++ b/README.md
@@ -20,7 +20,7 @@ SASjs is a open-source framework for building Web Apps on SAS® platforms. You c

 1 - `npm install @sasjs/adapter` - for use in a nodeJS project (recommended)

-2 - [Download](https://cdn.jsdelivr.net/npm/@sasjs/adapter@3/index.min.js) and use a copy of the latest JS file
+2 - [Download](https://cdn.jsdelivr.net/npm/@sasjs/adapter@4/index.min.js) and use a copy of the latest JS file

 3 - Reference directly from the CDN - in which case click [here](https://www.jsdelivr.com/package/npm/@sasjs/adapter?tab=collection) and select "SRI" to get the script tag with the integrity hash.

--- a/package-lock.json
+++ b/package-lock.json
--- a/package.json
+++ b/package.json
@@ -45,9 +45,7 @@
  "license": "ISC",
  "devDependencies": {
    "@cypress/webpack-preprocessor": "5.9.1",
-    "@types/axios": "0.14.0",
    "@types/express": "4.17.13",
-    "@types/form-data": "2.5.0",
    "@types/jest": "27.4.0",
    "@types/mime": "2.0.3",
    "@types/pem": "1.9.6",
@@ -71,8 +69,8 @@
    "ts-loader": "9.4.0",
    "tslint": "6.1.3",
    "tslint-config-prettier": "1.18.0",
-    "typedoc": "0.23.15",
-    "typedoc-plugin-rename-defaults": "0.4.0",
+    "typedoc": "0.23.24",
+    "typedoc-plugin-rename-defaults": "0.6.4",
    "typescript": "4.8.3",
    "webpack": "5.69.0",
    "webpack-cli": "4.9.2"
@@ -80,7 +78,7 @@
  "main": "index.js",
  "dependencies": {
    "@sasjs/utils": "2.52.0",
-    "axios": "0.26.0",
+    "axios": "0.27.2",
    "axios-cookiejar-support": "1.0.1",
    "form-data": "4.0.0",
    "https": "1.0.0",
--- a/sasjs-tests/src/testSuites/Basic.ts
+++ b/sasjs-tests/src/testSuites/Basic.ts
@@ -53,7 +53,9 @@ export const basicTests = (
        return await newAdapterIns.checkSession()
      },
      assertion: (response: any) =>
-        response?.isLoggedIn && response?.userName === userName
+        adapter.getSasjsConfig().serverType === ServerType.Sas9
+          ? response?.isLoggedIn
+          : response?.isLoggedIn && response?.userName === userName
    },
    {
      title: 'Multiple Log in attempts',
--- a/src/auth/AuthManager.ts
+++ b/src/auth/AuthManager.ts
@@ -141,7 +141,7 @@ export class AuthManager {
        await this.performCASSecurityCheck()
      }

-      this.loginCallback()
+      await this.loginCallback()
      this.userName = loginParams.username
    }

--- a/src/job-execution/WebJobExecutor.ts
+++ b/src/job-execution/WebJobExecutor.ts
@@ -16,7 +16,8 @@ import { SASViyaApiClient } from '../SASViyaApiClient'
 import {
  isRelativePath,
  parseSasViyaDebugResponse,
-  appendExtraResponseAttributes
+  appendExtraResponseAttributes,
+  getValidJson
 } from '../utils'
 import { BaseJobExecutor } from './JobExecutor'
 import { parseWeboutResponse } from '../utils/parseWeboutResponse'
@@ -183,6 +184,10 @@ export class WebJobExecutor extends BaseJobExecutor {
            }
          }

+          if (typeof jsonResponse === 'string') {
+            jsonResponse = getValidJson(jsonResponse)
+          }
+
          const responseObject = appendExtraResponseAttributes(
            { result: jsonResponse, log: res.log },
            extraResponseAttributes
Author	SHA1	Message	Date
Sabir Hassan	435993e50e	fix: sasjs-tests are passing on sas9 except one	2023-02-09 22:04:47 +05:00
Allan Bowe	2210e43880	chore: update README Thanks @saramartinelli1992 https://github.com/sasjs/adapter/issues/781#issuecomment-1420943632	2023-02-07 15:20:10 +00:00
Allan Bowe	b04df0bc6d	Merge pull request #779 from sasjs/issue-771 fix: bump axios version	2023-02-01 10:23:29 +00:00
Sabir Hassan	98e851b4d8	chore: npm audit fix	2023-01-31 23:08:56 +05:00
Sabir Hassan	84306bea3d	fix: bump axios version to 0.27.2	2023-01-31 23:05:54 +05:00
Sabir Hassan	89d32262f8	chore: form-data provides its own type definitions, so you do not need @types/form-data installed	2023-01-31 15:49:40 +05:00
Sabir Hassan	257010f57d	chore: axios provides its own type definitions, so you don't need @types/axios installed	2023-01-31 15:48:08 +05:00
Sabir Hassan	eb9991015b	chore: fix npm install	2023-01-31 15:45:49 +05:00