sasjs/lint
1
0
Fork 0
mirror of https://github.com/sasjs/lint.git synced 2025-12-10 17:34:36 +00:00
Code Issues Projects Releases Wiki Activity

fix: maxLineLength rule should be off when non positive number is provided

Browse Source
This commit is contained in:
Sabir Hassan
2023-01-10 20:55:21 +05:00
parent 5f0ef8616c
commit 54f887fc6d
2 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/types/LintConfig.spec.ts
View File

@@ -31,7 +31,7 @@ describe('LintConfig', () => {
).toBeUndefined()
})
it('should create an instance with the maxLineLength flag off', () => {
it('should create an instance with the maxLineLength flag off by setting value to 0', () => {
const config = new LintConfig({ maxLineLength: 0 })
expect(config).toBeTruthy()
@@ -42,6 +42,17 @@ describe('LintConfig', () => {
).toBeUndefined()
})
it('should create an instance with the maxLineLength flag off by setting value to a negative number', () => {
const config = new LintConfig({ maxLineLength: -1 })
expect(config).toBeTruthy()
expect(config.lineLintRules.length).toBeGreaterThan(0)
expect(config.fileLintRules.length).toBeGreaterThan(0)
expect(
config.lineLintRules.find((rule) => rule.name === 'maxLineLength')
).toBeUndefined()
})
it('should create an instance with the hasDoxygenHeader flag off', () => {
const config = new LintConfig({ hasDoxygenHeader: false })

7
src/types/LintConfig.ts
View File

@@ -68,12 +68,9 @@ export class LintConfig {
this.lineLintRules.pop()
}
if (json?.maxLineLength) {
if (json?.maxLineLength > 0) {
this.lineLintRules.push(maxLineLength)
if (!isNaN(json?.maxLineLength)) {
this.maxLineLength = json.maxLineLength
}
this.maxLineLength = json.maxLineLength
if (!isNaN(json?.maxHeaderLineLength)) {
this.maxHeaderLineLength = json.maxHeaderLineLength